Scenario: A player slot could be chosen with no effect

[kaputtnik]

Steps to reproduce:

- Select a Scenario (f.e. 'The green plateau')
- In menu "Launch Game" you could choose to play as another player (f.e. red player)

Result:
Starting the game you'll find yourself as the blue player, not the one you have chosen

Expected result:
Selecting another Player in menu "Launch Game" should not be possible if the scenario doesn't support this. Or: Immediately start the game without showing the menu "launch game" like it is when playing campaigns.

Reported in the forum by toptopple: https://wl.widelands.org/forum/topic/2051/

[SirVer (sirver)]

pretty sure this is a regression - but even if it is not, this is a fairly bad bug that needs fixing for b19.

Whoever tackles this should also look into multiplayer scenarios (for example island hopping) and see if choosing positions works as expected there.

[SirVer (sirver)]

I investigated and think that it is a bug that the UI allows for switching positions in single player scenarios. Since they are designed for one player only, it is easiest for the map designer to build it for a specific starting position - giving the ability to swap the starting position.

If a player wants to design a scenario that can be interesting from multiple positions, she can make a multiplayer scenario which allows for that.

I pushed a fix and proposed for merging.

[GunChleoc (gunchleoc)]

Fixed in build19-rc1.