Proftpd - MLSD lines not properly terminated with CRLF

[Jesse]

[Impact]

 * A bug exists in Proftpd version 1.3.5a. which causes FTP sessions to fail or timeout with strict clients

 * The package, as published in LTS, does not comply with the FTP protocol

 * Ported upstream patch and test changes

[Test Case]

 * Connect to an affected server with ftptest.net

 * Prior to the patch, it will fail to perform an MLSD command with an explicit error and explanation

 * After the patch, this works as expected

[Regression Potential]

 * Failures in SSL connection handling

A bug exists in Proftpd version 1.3.5a. which causes ssl sessions to fail or timeout with some clients

Excerpt from http://bugs.proftpd.org/show_bug.cgi?id=4202

Server seems to send an improperly formatted response causing some clients to
time out.

Log from ftptest.net:
[snip]
Command: TYPE I
Reply: 200 Type set to I
Command: EPSV
Reply: 229 Entering Extended Passive Mode (|||45766|)
Command: MLSD
Status: Data connection established.
Reply: 150 Opening BINARY mode data connection for MLSD
Error: Malformed directory listing
Error: Line feed received without preceding carriage return

This bug has been fixed upstream in version 1.3.5b I recommend getting this fixed this is causing a lot of havoc with my servers I've had to delay my rollout of 16.04 because of this.

[Amr Ibrahim (amribrahim1987)]

In the future, please use 'ubuntu-bug package-name' to report Ubuntu bugs.
https://help.ubuntu.com/community/ReportingBugs

You have reported a bug in a non-existent package in Ubuntu archives since 2007. No developer will see this bug report because simply the package does not exist any more.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Brian Morton (rokclimb15)]

https://github.com/proftpd/proftpd/pull/152

[Brian Morton (rokclimb15)]

Debdiff attached for Xenial along with before and after patch test logs from ftptest.net

[Brian Morton (rokclimb15)]

Test log before patch

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "Xenial debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

[Simon Quigley (tsimonq2)]

Unsubscribing ~ubuntu-sponsors for now because this is not ready to sponsor quite yet.

Please fill out the bug report as requested for SRUs in https://wiki.ubuntu.com/StableReleaseUpdates and resubscribe once that is done. Also, in your debdiff, please use the version "1.3.5a-1.1" instead of "1.3.5a-1build2"; the Security Team has a nice page describing version numbers in stable releases: https://wiki.ubuntu.com/SecurityTeam/UpdatePreparation#Update_the_packaging - and I would also exclude mention of that from the DEP-3 header (thanks for that!).

Thank you for your contribution to Ubuntu, and I look forward to getting this sorted!

[Brian Morton (rokclimb15)]

Hi Simon,

Thanks for your notes. I've attached a new patch and I'm adding SRU justification to the description now.

[Simon Quigley (tsimonq2)]

Uploaded with some minor DEP-3 header tweaks, a patch refresh, and I also added this bug number to the changelog.

Thank you for your contribution to Ubuntu, and apologies for the delay on getting this sponsored!

[Łukasz Zemczak (sil2100)]

Hello Jesse, or anyone else affected,

Accepted proftpd-dfsg into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/proftpd-dfsg/1.3.5a-1ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Simon Quigley (tsimonq2)]

Bump.

[Łukasz Zemczak (sil2100)]

Please perform verification on this bug, otherwise in a few days it will be removed as per the SRU policy.

[Brian Murray (brian-murray)]

The fix for this bug has been awaiting testing feedback in the -proposed repository for xenial for more than 90 days. Please test this fix and update the bug appropriately with the results. In the event that the fix for this bug is still not verified 15 days from now, the package will be removed from the -proposed repository.

[Brian Morton (rokclimb15)]

Verified successfully in 1.3.5a-1ubuntu0.1

Command: MLSD
Status: Data connection established.
Reply: 150 Opening BINARY mode data connection for MLSD

Listing: modify=20181119215133;perm=fle;type=pdir;unique=9AU7A5;UNIX.group=0;UNIX.mode=0755;UNIX.owner=0; ..

Reply: 226 Transfer complete
Status: Success

[Launchpad Janitor (janitor)]

This bug was fixed in the package proftpd-dfsg - 1.3.5a-1ubuntu0.1

---------------
proftpd-dfsg (1.3.5a-1ubuntu0.1) xenial; urgency=medium

  * Add upstream patch for CRLF to MLSD response (LP: #1613737).

 -- Brian Morton <email address hidden> Fri, 1 Dec 2017 16:05:00 -0500

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for proftpd-dfsg has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.