OpenStack Shared File Systems Service (Manila)

After failure in create from snap Manila HNAS driver does not cleanup

Bug #1613721 reported by Alyson on 2016-08-16

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Shared File Systems Service (Manila)	Fix Released	Medium	Alyson	OpenStack Shared File Systems Service (Manila) newton-rc1 "RC1"

Bug Description

When the nfs_export_add or cifs_share_add operations fails while creating a new share from a snapshot due to some reason, the directory, virtual-volume and quota is not cleaned up from HNAS backend. This things has to be manually cleaned up from backend.

We need to add a clean up flow in case of a failure into the driver.

Tags:

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-08-16: Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/356087

Changed in manila:
assignee:	nobody → Alyson (alyson-rodrigues-rosa)
status:	New → In Progress

Rodrigo Barbieri (rodrigo-barbieri2010) on 2016-09-08

Changed in manila:
milestone:	none → newton-rc1
importance:	Undecided → Medium

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-09-14: Fix merged to manila (master)

Reviewed: https://review.openstack.org/356087
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=9d6823b3eaf289139e415f025b507901b419b8e4
Submitter: Jenkins
Branch: master

commit 9d6823b3eaf289139e415f025b507901b419b8e4
Author: Alyson Rosa <email address hidden>
Date: Tue Aug 16 15:00:24 2016 -0300

Add cleanup to create from snap in Manila HNAS driver

Adding a cleanup to method create_from_snapshot in case
of a failure.

Also, raising the correct exception on backend layer in
case of a failure when exporting shares.

Change-Id: I86d2c3c5ff5a790868f8362e065df1eb2be8a3ad
Closes-Bug: #1613721

Changed in manila:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-09-15: Fix proposed to manila (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/370815

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-09-16: Fix merged to manila (stable/mitaka)

Reviewed: https://review.openstack.org/370815
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=05312049717161f77aba397e69cb323dae57ec73
Submitter: Jenkins
Branch: stable/mitaka

commit 05312049717161f77aba397e69cb323dae57ec73
Author: Alyson Rosa <email address hidden>
Date: Tue Aug 16 15:00:24 2016 -0300

Add cleanup to create from snap in Manila HNAS driver

Adding a cleanup to method create_from_snapshot in case
of a failure.

Also, raising the correct exception on backend layer in
case of a failure when exporting shares.

    Conflicts:
           manila/share/drivers/hitachi/hds_hnas.py
           manila/share/drivers/hitachi/ssh.py
           manila/tests/share/drivers/hitachi/hnas/test_driver.py
           manila/tests/share/drivers/hitachi/test_ssh.py

    Change-Id: I86d2c3c5ff5a790868f8362e065df1eb2be8a3ad
    Closes-Bug: #1613721
    (cherry picked from commit 9d6823b3eaf289139e415f025b507901b419b8e4)