Menu items don't reflect state changes

[Stephen Brandt]

Hi,

I was testing my application [1] in elementaryOS 0.4 beta 2 and noticed the menu items of the indicator did not update according to state changes inside Wingpanel. When Haguichi changes mode (for example from "Connected" to "Disconnected") a signal is send over DBus to the indicator, which will then change the icon and menu items accordingly [2].

The *icon* change is reflected correctly in Wingpanel (so there's no DBus problem), however the menu item properties (visibility, sensitivity, toggle state) are not reflected in the menu.

This bug is *not* present in elementaryOS 0.3.2. See attached screenshot for comparison between Ubuntu 16.04, elementaryOS 0.3.2 and elementaryOS 0.4 beta 2.

[1] https://www.haguichi.net/
[2] http://bazaar.launchpad.net/~ztefn/haguichi-indicator/0.3/view/head:/src/indicator-menu.vala#L217

[Djax (parnold-x)]

Thanks for the bug report. The attached branch should fix it.

[Stephen Brandt (ztefn)]

I've tested the branch. Visibility and sensitivity states seems to have been fixed indeed.

However the "active" state of the "Show Haguichi" CheckMenuItem still doesn't change when the window is hidden or shown [1].

I'm sorry for not explicitly mentioning that state had signal problems too in my report.

[1] http://bazaar.launchpad.net/~ztefn/haguichi-indicator/0.3/view/head:/src/indicator-menu.vala#L162

[Djax (parnold-x)]

Thanks, missed that. Updated.

[Stephen Brandt (ztefn)]

Works perfectly now. Thanks for fixing!