[tripleo-common] Exclude more unneeded files from default plan

Bug #1613286 reported by Florian Fuchs
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Florian Fuchs

Bug Description

When a default plan is created (via the tripleo.plan_management.v1.create_default_deployment_plan workflow), a tarball of the complete /usr/share/openstack-tripleo-heat-templates/ directory will be created and uploaded to swift.

This is a bit problematic:

- It bloats the plan, since it contains unneeded files.
- If one of the py scripts contained in the folder is executed and a .pyc file is created, this file is added to the plan as well. As a consequence the plan cannot be (JSON-)serialized any more at a later stage.

The function that creates the tarball (tripleo_common.utils.tarball.create_tarball) already excludes the .tox and .git folders from the archive. I suggest adding at least all .py(c|o), .pp, and .sh files from the archive as well.

Revision history for this message
Julie Pichon (jpichon) wrote :

Patch at https://review.openstack.org/#/c/355472/ , since the automatic linking doesn't seem to have worked

tags: added: common
Changed in tripleo:
status: New → In Progress
Changed in tripleo:
assignee: nobody → Florian Fuchs (flo-fuchs)
importance: Undecided → High
milestone: none → newton-3
Revision history for this message
Julie Pichon (jpichon) wrote :

This is merged, updating status.

Changed in tripleo:
status: In Progress → Fix Committed
tags: added: tripleo-common
removed: common
Changed in tripleo:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 5.0.0

This issue was fixed in the openstack/tripleo-common 5.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.