SYMC: Agent crash in InstanceTaskExecvp::ReadErrors

[Hari Prasad Killi]

(gdb) bt
#0 0x00007f72e9a57414 in pthread_mutex_lock () from /lib/x86_64-linux-gnu/libpthread.so.0
#1 0x000000000097f1a0 in lock (this=0x11f) at /usr/include/boost/asio/detail/posix_mutex.hpp:52
#2 scoped_lock (m=..., this=<synthetic pointer>) at /usr/include/boost/asio/detail/scoped_lock.hpp:46
#3 boost::asio::detail::epoll_reactor::deregister_descriptor (this=0x7f72b40080c8, descriptor=1813217640, descriptor_data=@0x7f726c299848: 0xf7, closing=<optimized out>)
    at /usr/include/boost/asio/detail/impl/epoll_reactor.ipp:307
#4 0x000000000099ad95 in close (ec=..., impl=..., this=<optimized out>) at /usr/include/boost/asio/detail/impl/reactive_descriptor_service.ipp:128
#5 close (ec=..., impl=..., this=<optimized out>) at /usr/include/boost/asio/posix/stream_descriptor_service.hpp:129
#6 close (ec=..., this=0x7f726c299838) at /usr/include/boost/asio/posix/basic_descriptor.hpp:222
#7 InstanceTaskExecvp::ReadErrors (this=0x7f726c2997d0, ec=..., read_bytes=<optimized out>) at controller/src/vnsw/agent/oper/instance_task.cc:29
#8 0x000000000099cb85 in operator() (a2=<optimized out>, a1=..., p=<optimized out>, this=<optimized out>) at /usr/include/boost/bind/mem_fn_template.hpp:280

The InstanceTaskExecvp object is invalid.

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/23248
Submitter: Hari Prasad Killi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/23319
Submitter: Hari Prasad Killi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/23319
Committed: http://github.org/Juniper/contrail-controller/commit/f5b38972b8a1dcdf8de5cb84cc05192a8c146187
Submitter: Zuul
Branch: R2.21.x

commit f5b38972b8a1dcdf8de5cb84cc05192a8c146187
Author: Hari <email address hidden>
Date: Tue Aug 16 12:16:27 2016 +0530

Delete Instance Task only in exit handler.

We currently have a delete of instance task object after terminating the task
as well. This could result in accessing a deleted instance task object (eg. when
the small timeout value is configured or when task exit takes long). Changing
this to delete only via exit handler.

Change-Id: I062400dae5ba580a44fdb4ce0c4c48994e9c1b95
closes-bug: #1612354

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/23361
Submitter: Hari Prasad Killi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/23362
Submitter: Hari Prasad Killi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/23368
Submitter: Hari Prasad Killi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/23369
Submitter: Hari Prasad Killi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/23370
Submitter: Hari Prasad Killi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/23369
Committed: http://github.org/Juniper/contrail-controller/commit/01c577cd529e289f63dc156f51242b700082d6dc
Submitter: Zuul
Branch: master

commit 01c577cd529e289f63dc156f51242b700082d6dc
Author: Hari <email address hidden>
Date: Tue Aug 16 12:16:27 2016 +0530

Delete Instance Task only in exit handler.

We currently have a delete of instance task object after terminating the task
as well. This could result in accessing a deleted instance task object (eg. when
the small timeout value is configured or when task exit takes long). Changing
this to delete only via exit handler.

Change-Id: I062400dae5ba580a44fdb4ce0c4c48994e9c1b95
closes-bug: #1612354
(cherry picked from commit 361318f821fae8f7bd6e2a75687e33cff609f696)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/23362
Committed: http://github.org/Juniper/contrail-controller/commit/e4f422b0329ca0f8eec6856095b017bfd0e3dbb4
Submitter: Zuul
Branch: R2.20

commit e4f422b0329ca0f8eec6856095b017bfd0e3dbb4
Author: Hari <email address hidden>
Date: Tue Aug 16 12:16:27 2016 +0530

Delete Instance Task only in exit handler.

We currently have a delete of instance task object after terminating the task
as well. This could result in accessing a deleted instance task object (eg. when
the small timeout value is configured or when task exit takes long). Changing
this to delete only via exit handler.

Change-Id: I062400dae5ba580a44fdb4ce0c4c48994e9c1b95
closes-bug: #1612354
(cherry picked from commit f5b38972b8a1dcdf8de5cb84cc05192a8c146187)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/23370
Committed: http://github.org/Juniper/contrail-controller/commit/0cedfc5f7d3ae6a56d488406dfd1ff3e116fa2d6
Submitter: Zuul
Branch: R3.0

commit 0cedfc5f7d3ae6a56d488406dfd1ff3e116fa2d6
Author: Hari <email address hidden>
Date: Tue Aug 16 12:16:27 2016 +0530

Delete Instance Task only in exit handler.

We currently have a delete of instance task object after terminating the task
as well. This could result in accessing a deleted instance task object (eg. when
the small timeout value is configured or when task exit takes long). Changing
this to delete only via exit handler.

Change-Id: I062400dae5ba580a44fdb4ce0c4c48994e9c1b95
closes-bug: #1612354
(cherry picked from commit f5b38972b8a1dcdf8de5cb84cc05192a8c146187)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/23368
Committed: http://github.org/Juniper/contrail-controller/commit/361318f821fae8f7bd6e2a75687e33cff609f696
Submitter: Zuul
Branch: R3.1

commit 361318f821fae8f7bd6e2a75687e33cff609f696
Author: Hari <email address hidden>
Date: Tue Aug 16 12:16:27 2016 +0530

Delete Instance Task only in exit handler.

We currently have a delete of instance task object after terminating the task
as well. This could result in accessing a deleted instance task object (eg. when
the small timeout value is configured or when task exit takes long). Changing
this to delete only via exit handler.

Conflicts:
 src/vnsw/agent/oper/instance_task.cc
 src/vnsw/agent/oper/instance_task.h

Change-Id: I062400dae5ba580a44fdb4ce0c4c48994e9c1b95
closes-bug: #1612354
(cherry picked from commit f5b38972b8a1dcdf8de5cb84cc05192a8c146187)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/23361
Committed: http://github.org/Juniper/contrail-controller/commit/43cc7377c964933514cb1a7bdff132064b9eeec5
Submitter: Zuul
Branch: R2.22.x

commit 43cc7377c964933514cb1a7bdff132064b9eeec5
Author: Hari <email address hidden>
Date: Tue Aug 16 12:16:27 2016 +0530

Delete Instance Task only in exit handler.

We currently have a delete of instance task object after terminating the task
as well. This could result in accessing a deleted instance task object (eg. when
the small timeout value is configured or when task exit takes long). Changing
this to delete only via exit handler.

Change-Id: I062400dae5ba580a44fdb4ce0c4c48994e9c1b95
closes-bug: #1612354
(cherry picked from commit f5b38972b8a1dcdf8de5cb84cc05192a8c146187)