Plugin deployment errors hidden in astute debug log

[Bob Ball]

Detailed description:
When a plugin fails to deploy, an error is reported to the UI and shown in the astute log, for example:
[461] Error running RPC method granular_deploy: Failed to execute hook 'compute-post-deployment' Failed to run command cd /etc/fuel/plugins/fuel-plugin-ics-3.90/ && ./compute_post_deployment.py --- uids: - '13' parameters: cmd: ./compute_post_deployment.py cwd: /etc/fuel/plugins/fuel-plugin-ics-3.90/ timeout: 300 priority: 300 fail_on_error: true type: shell id: compute-post-deployment

The actual failure is also included in the astute log, but only visible when you show DEBUG logs, and hidden below several other DEBUG prints from this failure making it non-obvious what the error was.

For example:
2016-08-10 13:16:05 DEBUG [461] f4aecd3c-bbe8-4422-9690-8a9a7515de14: cmd: cd /etc/fuel/plugins/fuel-plugin-ics-3.90/ && ./compute_post_deployment.py
cwd: /etc/fuel/plugins/fuel-plugin-ics-3.90/
stdout:
stderr: Traceback (most recent call last):
  File "./compute_post_deployment.py", line 498, in <module>
    check_local_sr(HIMN_IP, username)
  File "./compute_post_deployment.py", line 230, in check_local_sr
    reportError(('Default SR type should be EXT or NFS. If using local storage, Please make sure thin'
  File "./compute_post_deployment.py", line 36, in reportError
    raise Exception(err)
Exception: Default SR type should be EXT or NFS. If using local storage, Please make sure thin provisioning is enabled on your host during installation.
exit code: 1

Steps to reproduce:
Install a plugin and manipulate things in such a way that installation will fail (e.g. set the wrong password for a XenServer host.

Expected result:
Exception returned from the plugin is shown in the ERROR logs as a minimum, with preference to the Exception message also being displayed in the main UI as the reason for the failure to deploy.

Actual result:
Opaque message "Inspect astute logs" with the actual failure not obviously visible as it's hidden in DEBUG output

Reproducibility:
100%

Workaround:
View all debug logs for astute to view the plug-in error message

Impact:
It makes assisting customers who are deploying this difficult as error messages are not prominently displayed

[Vladimir Kuklin (vkuklin)]

This issue has been fixed since 9.0 with new task-based deployment engine which essentially provides deployment tasks history feature. Please assign to <9 releases if you need it to be fixed there.