purge_config not working for some classes

[Brent Eagles]

Remnants of old configuration and/or garbage settings are not being cleaned up when purge_config is set to true for some classes including, but not limited to ::nova and ::neutron.

The code for the providers for these classes differ from the majority of other providers.

[Brent Eagles (beagles)]

When investigating this issue, a "can't generate additional resources" error mentioning namevar method not found was displayed. Adding a namevar method to the provider code resolves the error, after which purging also works for that class. e.g. https://review.openstack.org/#/c/353802/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/353814

[Brent Eagles (beagles)]

Further info:

I've tried a few variations on fixes, including changing puppet-neutron/lib/puppet/provider/neutron_config.rb to use the ini_setting provider like the other provider implementations do. For example:

Puppet::Type.type(:neutron_config).provide(
  :openstackconfig,
  :parent => Puppet::Type.type(:openstack_config).provider(:ini_setting)
) do

...

What happens is that neutron class parameters such as neutron::bind_port which are defaulted to $::os_service_default result in entries like:

bind_port = ["<SERVICE DEFAULT>"]

in the config file.

Actually it appears that all class parameters that have a default of $::os_service_default are resulting in configuration entries being added with this value. In other words, they are not behaving as though they were unset.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Brent Eagles (<email address hidden>) on branch: master
Review: https://review.openstack.org/353814
Reason: https://review.openstack.org/#/c/354096/ should handle this.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Brent Eagles (<email address hidden>) on branch: master
Review: https://review.openstack.org/353802
Reason: https://review.openstack.org/#/c/354096/ should handle this.

[Brent Eagles (beagles)]

This is fixed by adding the namevar method https://review.openstack.org/#/c/354096/ as opposed to the individual modules.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/puppet-openstacklib 9.2.0 release.