No validation against coding standards
Bug #1611784 reported by
dobey
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| ubuntu-app-launch (Ubuntu) |
New
|
Medium
|
Unassigned | ||
Bug Description
This project has no test to verify the code follows the coding standard detailed at https:/
Related branches
lp:~dobey/ubuntu-app-launch/fix-clang-format
- unity-api-1-bot: Needs Fixing (continuous-integration)
- Unity API Team: Pending requested
-
Diff: 28897 lines (+13310/-13468)87 files modified.clang-format (+51/-19)
CMakeLists.txt (+16/-0)
application-failed.c (+47/-49)
application-job.c (+83/-90)
cgroup-reap-all.c (+41/-43)
debian/control (+2/-1)
desktop-hook.c (+549/-543)
exec-line-exec.c (+138/-140)
helpers-shared.c (+213/-231)
helpers.c (+560/-568)
helpers.h (+21/-31)
libubuntu-app-launch/CMakeLists.txt (+0/-4)
libubuntu-app-launch/app-info.c (+295/-300)
libubuntu-app-launch/app-info.h (+9/-5)
libubuntu-app-launch/appid.h (+123/-119)
libubuntu-app-launch/application-icon-finder.cpp (+255/-286)
libubuntu-app-launch/application-icon-finder.h (+59/-54)
libubuntu-app-launch/application-impl-base.cpp (+103/-134)
libubuntu-app-launch/application-impl-base.h (+18/-20)
libubuntu-app-launch/application-impl-click.cpp (+118/-125)
libubuntu-app-launch/application-impl-click.h (+25/-27)
libubuntu-app-launch/application-impl-legacy.cpp (+108/-123)
libubuntu-app-launch/application-impl-legacy.h (+26/-29)
libubuntu-app-launch/application-impl-libertine.cpp (+94/-107)
libubuntu-app-launch/application-impl-libertine.h (+23/-28)
libubuntu-app-launch/application-info-desktop.cpp (+183/-204)
libubuntu-app-launch/application-info-desktop.h (+42/-60)
libubuntu-app-launch/application.cpp (+146/-174)
libubuntu-app-launch/application.h (+194/-197)
libubuntu-app-launch/click-exec.c (+141/-133)
libubuntu-app-launch/click-exec.h (+4/-5)
libubuntu-app-launch/desktop-exec.c (+183/-181)
libubuntu-app-launch/desktop-exec.h (+4/-4)
libubuntu-app-launch/glib-thread.cpp (+133/-132)
libubuntu-app-launch/glib-thread.h (+59/-65)
libubuntu-app-launch/helper-impl-click.cpp (+124/-129)
libubuntu-app-launch/helper-impl-click.h (+27/-34)
libubuntu-app-launch/helper.cpp (+6/-8)
libubuntu-app-launch/helper.h (+57/-58)
libubuntu-app-launch/recoverable-problem.c (+110/-129)
libubuntu-app-launch/recoverable-problem.h (+3/-5)
libubuntu-app-launch/registry-impl.cpp (+138/-143)
libubuntu-app-launch/registry-impl.h (+23/-29)
libubuntu-app-launch/registry.cpp (+44/-54)
libubuntu-app-launch/registry.h (+61/-60)
libubuntu-app-launch/second-exec-core.c (+382/-419)
libubuntu-app-launch/second-exec-core.h (+1/-2)
libubuntu-app-launch/type-tagger.h (+17/-32)
libubuntu-app-launch/ubuntu-app-launch.c (+2157/-2243)
libubuntu-app-launch/ubuntu-app-launch.h (+115/-104)
oom-adjust-setuid-helper.c (+94/-90)
socket-demangler.c (+93/-101)
tests/CMakeLists.txt (+0/-6)
tests/application-icon-finder.cpp (+72/-75)
tests/application-info-desktop.cpp (+212/-150)
tests/cgroup-reap-test.cc (+117/-120)
tests/data-spew.c (+12/-16)
tests/exec-util-test.cc (+312/-286)
tests/failure-test.cc (+131/-126)
tests/helper-handshake-test.cc (+93/-95)
tests/helper-test.cc (+458/-433)
tests/libual-cpp-test.cc (+1650/-1541)
tests/libual-test.cc (+1652/-1620)
tests/mir-mock.cpp (+74/-90)
tests/mir-mock.h (+4/-4)
tests/socket-tool.c (+20/-23)
tests/test-code-format.sh (+14/-0)
tests/ubuntu-app-launch-mock.c (+8/-12)
tests/ubuntu-app-launch-mock.h (+1/-2)
tests/zg-test.cc (+104/-100)
tools/ubuntu-app-info.cpp (+65/-51)
tools/ubuntu-app-launch.c (+63/-63)
tools/ubuntu-app-list-pids.cpp (+28/-30)
tools/ubuntu-app-list.cpp (+9/-11)
tools/ubuntu-app-pid.cpp (+30/-32)
tools/ubuntu-app-stop.cpp (+26/-27)
tools/ubuntu-app-triplet.cpp (+23/-24)
tools/ubuntu-app-usage.c (+161/-170)
tools/ubuntu-app-watch.c (+69/-85)
tools/ubuntu-helper-list.cpp (+15/-18)
tools/ubuntu-helper-start.cpp (+27/-28)
tools/ubuntu-helper-stop.cpp (+30/-32)
ual-tracepoint.h (+9/-9)
ubuntu-app-test/src/ubuntu-app-test.c (+96/-99)
untrusted-helper-type-end.c (+45/-43)
xmir-helper.c (+79/-89)
zg-report-app.c (+83/-87)
lp:~ted/ubuntu-app-launch/reformat-all-the-things
- dobey (community): Needs Information
- unity-api-1-bot: Needs Fixing (continuous-integration)
-
Diff: 470 lines (+61/-90)6 files modifiedCMakeLists.txt (+26/-0)
_clang-format (+0/-48)
libubuntu-app-launch/CMakeLists.txt (+4/-4)
tests/CMakeLists.txt (+17/-18)
tools/CMakeLists.txt (+13/-20)
ubuntu-app-test/src/CMakeLists.txt (+1/-0)
| Changed in ubuntu-app-launch (Ubuntu): | |
| status: | New → In Progress |
| assignee: | nobody → Rodney Dawes (dobey) |
Revision history for this message
| Ted Gould (ted) wrote | #1 |
| Changed in ubuntu-app-launch (Ubuntu): | |
| status: | In Progress → Confirmed |
| importance: | High → Wishlist |
| assignee: | Rodney Dawes (dobey) → nobody |
| summary: |
- No validation against coding standards + Should use the CMake Extras Coding Standard rules as tests and + reformating |
| Changed in ubuntu-app-launch (Ubuntu): | |
| assignee: | nobody → Rodney Dawes (dobey) |
| status: | Confirmed → In Progress |
| summary: |
- Should use the CMake Extras Coding Standard rules as tests and - reformating + No validation against coding standards |
| Changed in ubuntu-app-launch (Ubuntu): | |
| importance: | Wishlist → High |
| Changed in ubuntu-app-launch (Ubuntu): | |
| importance: | High → Medium |
| Changed in ubuntu-app-launch (Ubuntu): | |
| assignee: | Rodney Dawes (dobey) → nobody |
| status: | In Progress → New |
To post a comment you must log in.
We plan to use the cmake extras tools for this when they can support different targets. That is a planned feature there.