Adding members via Institutions -> members is broken

Bug #1611547 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Robert Lyon

Bug Description

Turns out the patch 83069d9effc9707cf3aa1f72c8e7de8ecd78e6a4 (Purge MochiKit from mahara.js) broke the ability to add members to an institution via Institution -> Members

The js returns a TypeError: data is null

I suspect that all the pages using the double textarea box setup will be broken

Tags: regression
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/6825

Robert Lyon (robertl-9)
Changed in mahara:
status: Confirmed → In Progress
assignee: nobody → Robert Lyon (robertl-9)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/6825
Committed: https://git.mahara.org/mahara/mahara/commit/4e585756de5e3145615ee54749b673450e27bf22
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit 4e585756de5e3145615ee54749b673450e27bf22
Author: Robert Lyon <email address hidden>
Date: Thu Aug 11 20:56:11 2016 +1200

Bug 1611547: Problem with userlist forms

The forms are not rendering correctly now that we have removed
mochikit from mahara.js

The problem is the typeof(message) check can return 'object' when the
message is null - see http://www.ecma-international.org/ecma-262/5.1/#sec-11.4.3

So need to avoid trying to get the sub message from null object

Also added some accessibility strings to the Institutions -> Members
add form

Change-Id: Ic0a02ef35d5d0ed1844ab5792542fe0872e5376f
Signed-off-by: Robert Lyon <email address hidden>

Aaron Wells (u-aaronw)
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.