Throw meaningful exception on POST to ports with misconfigured network

[Kyle Haley]

This will throw a 500 KeyError if a user attempts to create a port on a network that is not configured using the unmanaged driver. We need to throw a meaningful exception.

    def create_port(self, context, network_id, port_id, **kwargs):
        LOG.info("create_port %s %s %s" % (context.tenant_id, network_id,
                                           port_id))
        bridge_name = STRATEGY.get_network(network_id)["bridge"]
        return {"uuid": port_id, "bridge": bridge_name}

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/352998

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/352998
Committed: https://git.openstack.org/cgit/openstack/quark/commit/?id=c6f52079673fd2eeffde40ae778577cb9005edcb
Submitter: Jenkins
Branch: master

commit c6f52079673fd2eeffde40ae778577cb9005edcb
Author: Kyle Haley <email address hidden>
Date: Tue Aug 9 08:33:33 2016 -0700

    Throw meaningful exception bad network config

    In the unmanaged driver, create port will fail with a KeyError
    if a network_id is used that isn't configured properly in
    neutron.conf (ie - bridge isn't defined). Added checks and
    meaningful error for users.

    Change-Id: Ief9c2371100063ff679858abc5fdf7cc24ec9dda
    Closes-Bug: #1611440
    JIRA:NCP-2012