[tripleoclient] Wrong message displayed when running introspect_manageable_nodes workflow

Bug #1611284 reported by Julie Pichon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Medium
Julie Pichon

Bug Description

$ openstack overcloud node introspect --all-manageable
Waiting for introspection to finish...
Introspection for UUID 789ffc89-1e98-47bb-95e1-632461781730 finished successfully.
Introspection for UUID c33c3f6d-a96e-4a4d-9815-a799e88ede56 finished successfully.
No nodes in manageable state found for introspection. <---------------- This shouldn't be here
Introspection completed.

I think this is happening because the loop [1] uses an 'else' clause to pick up errors though there's no 'break' statement.

[1] https://github.com/openstack/python-tripleoclient/blob/master/tripleoclient/workflows/baremetal.py#L127-L139

Julie Pichon (jpichon)
Changed in tripleo:
assignee: nobody → Julie Pichon (jpichon)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/352783

Changed in tripleo:
status: New → In Progress
Changed in tripleo:
milestone: none → newton-3
Steven Hardy (shardy)
Changed in tripleo:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (master)

Reviewed: https://review.openstack.org/352783
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=039f8c537c832989d2f394565ff7cec58b333469
Submitter: Jenkins
Branch: master

commit 039f8c537c832989d2f394565ff7cec58b333469
Author: Julie Pichon <email address hidden>
Date: Tue Aug 9 09:22:25 2016 +0100

    Fix 'no nodes found' message in introspect manageable nodes workflow

    The message was always displayed even after successfully introspecting
    nodes.

    Change-Id: Ib97e7f2d2b233c2e7b91576141f920c32fc2e1cf
    Closes-Bug: #1611284

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 5.0.0

This issue was fixed in the openstack/python-tripleoclient 5.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.