Behaviour of exiting children is broken

Bug #161121 reported by Chris Jones
4
Affects Status Importance Assigned to Milestone
Terminator
Fix Released
Critical
Chris Jones

Bug Description

When a child shell exits, it should either restart or cause the terminal it lives in to be removed from the heirarchy. Currently it simply leaves a useless terminal that can never be saved.

Related branches

Chris Jones (cmsj)
Changed in terminator:
assignee: nobody → cmsj
importance: Undecided → Critical
milestone: none → 1.0-beta
status: New → Triaged
Revision history for this message
Chris Jones (cmsj) wrote :

Fixed in revision 91. This now entirely follows gnome-terminal behaviour. Terminals will either close themselves (thus removing them from the heirarchy) or respawn their child.

Changed in terminator:
status: Triaged → Fix Committed
Revision history for this message
Chris Jones (cmsj) wrote :

Setting this back to In Progress because I think the "Are you sure you want to close this terminal?" question is unnecessary and should probably go away, at least in some situations.

Changed in terminator:
status: Fix Committed → In Progress
Revision history for this message
Huanghe (henry3) wrote :

I think it is important. We alway press exit to close the terminal.

Revision history for this message
Chris Jones (cmsj) wrote :

How do you mean?

For reference - I absolutely do not want to remove the question you get when you try to close the whole window, I just think that the question shouldn't be asked for individual terminals.

My justification for this is mostly that gnome-terminal doesn't ask if it should exit or not when you have a single terminal open. You either typed "exit" or closed its window. The same applies to a terminal in Terminator.

Revision history for this message
Thomas Meire (blackskad) wrote :

I created a branch which tries to mimic the behavior of gnome-terminal as good as possible. I removed the confirmation-dialogs when closing a single VTE (as gnome-terminal doesn't show it either). The key-combo was changed to ctrl-shift-w. The confirmation-dialog when closing the main window has been enhanced a little too.

The branch is located at https://code.launchpad.net/~blackskad/terminator/mimic-terminator

Revision history for this message
Chris Jones (cmsj) wrote :

I've merged this branch into trunk. ^W makes much more sense, but for kicks I've put ^Q in as well as a shortcut for exiting Terminator. Thanks Thomas!

Changed in terminator:
status: In Progress → Fix Committed
Revision history for this message
Chris Jones (cmsj) wrote :

Fixed in 0.7

Changed in terminator:
status: Fix Committed → Fix Released
Revision history for this message
youzoe7 (lynnuzzo) wrote :

there is a guy in my neigborhood that hangsout with teens and poses them imaprtally

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.