update_floatingip: allow kuryr owner

Bug #1610488 reported by Antoni Segura Puimedon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
networking-midonet
Fix Released
High
YAMAMOTO Takashi

Bug Description

Patch Change-Id: I36c6397c35b4fae4c35c8f61f7778b70ca206d9a "l3: Allow floating-ip association to VIP" added support for 3rd party LB pool floating ip association. Unfortunately, the only other allowed value in the check is for strings that start with DEVICE_OWNER_COMPUTE_PREFIX. This disqualifies Neutron ports owned by kuryr, since their owner id is: "kuryr:container".

Revision history for this message
Antoni Segura Puimedon (celebdor) wrote :

we have the constant defined in kuryr-lib, but since it not released yet nor I think networking-midonet should depend on it, the best is probably to define the value in neutron or in networking-midonet.

Changed in networking-midonet:
importance: Undecided → High
milestone: none → 3.0.0
status: New → Confirmed
Changed in networking-midonet:
assignee: nobody → YAMAMOTO Takashi (yamamoto)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to networking-midonet (master)

Fix proposed to branch: master
Review: https://review.openstack.org/352641

Changed in networking-midonet:
status: Confirmed → In Progress
tags: added: mitaka-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-midonet (master)

Reviewed: https://review.openstack.org/352641
Committed: https://git.openstack.org/cgit/openstack/networking-midonet/commit/?id=806b837bbff871461538f181b22766598ca1de40
Submitter: Jenkins
Branch: master

commit 806b837bbff871461538f181b22766598ca1de40
Author: YAMAMOTO Takashi <email address hidden>
Date: Tue Aug 9 08:18:52 2016 +0900

    l3: Remove device_owner validation for FIP association

    The purpose of the check was to avoid user confusion due to
    neutron db vs backend mismatch. Given that we use the ERROR state [1]
    these days, it's no longer too useful.

    On the other hand, the recent versions of kuryr use a device_owner
    which is not known to networking-midonet or midonet. ("kuryr:container")
    This commit removes the check to allow such a usage.

    Note: As far as the cluster rest api is used, MidoNet handles unknown
    device_owner values as COMPUTE. (Task-based api is a different story
    though)

    [1] Id3bfb87c80f66293340bee0eff5c77eb64dbd522

    Closes-Bug: #1610488
    Related-Bug: #1535211
    Change-Id: I873ea39c029cded09a5c24e497846ec62d292638

Changed in networking-midonet:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/networking-midonet 3.0.0

This issue was fixed in the openstack/networking-midonet 3.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.