[cinder] retype command doesn't delete volume on solidfire

[Andrey Grebennikov]

MOS8 with netapp nfs and solidfire (iscsi) backends for cinder.
Customer wants to execute volume retyping sometimes, and it turns out retyping works fine for netapp->solidfire, but has an issue with solidfire->netapp.
In this case the volume gets created on the netapp, the data is transferred, but the source volume never gets deleted on solidfire.

The log says:
2016-08-04 19:09:23.652 28961 ERROR cinder.volume.drivers.solidfire [req-b2cc5e26-06b4-454a-910a-c454155e81eb 79d85a14c1a34a758a747e668bafe10f 563d9b14b7a1464f9bfbfbc4cc4c49d5 - - -] Volume ID 9f2ee348-10be-4f33-
97a3-9dc18aab6486 was not found on the SolidFire Cluster while attempting delete_volume operation!
Which is wrong - the temporary volume ID is used in this case, not the original one.

In solidfire driver it is necessary to use "name_id" value from the volume object instead of "id".

[Ivan Kolodyazhny (e0ne)]

Fix: http://paste.openstack.org/show/549296/

[Ivan Kolodyazhny (e0ne)]

Patch for MOS 8 https://review.fuel-infra.org/24805 merged

[Ivan Kolodyazhny (e0ne)]

Patch was verified on customer's environment

[TatyanaGladysheva (tgladysheva)]

Move to Fix Released according to the previous comment #3.
Fix for 8.0 is available in MU3 updates.

[Timur Nurlygayanov (tnurlygayanov)]

It is not clear how to verify the fix (steps to reproduce require some plugins), I've checked the code on my MOS 9.1 environment and fix is presented here, since the fix was tested on the customer env we marked this issue Fix Released for 9.1 and 10.0 releases as well.