[RFE] Allow both RFC3986 and FQDNs in Node Registration 'Name' field

[Dan Trainor]

When "Upload From File" is used to Register nodes in the UI, the dialogue provides post-import configuration options. One of these options is for the value of 'Name'

This is likely a limitation of how Ironic stores and maintains node names. According to the Ironic WebAPI V1 spec[1], version 1.10 incorporated the usage of RFC3986 unreserved characters. This was in addition to valid FQDNs. The form field validation is only looking for valid RFC3986 unreserved characters, not both RFC3986 unreserved characters AND valid FQDNs.

The form field validation should support both RFC3986 unreserved characters and valid FQDNs.

[1] http://docs.openstack.org/developer/ironic/webapi/v1.html

[Julie Pichon (jpichon)]

I wonder if that name validation is appropriate at all, looking at http://developer.openstack.org/api-ref/baremetal/?expanded=create-node-detail it sounds like the 'name' can be pretty-much free-form since 1.5? The URL mentioned in the bug is no longer valid so I'm not sure where to double-check the reference. See also bug 1632631.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/385418

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/386199

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/385418
Committed: https://git.openstack.org/cgit/openstack/tripleo-ui/commit/?id=228aa2ab6aace295dcb531eccb1528d9edaca045
Submitter: Jenkins
Branch: master

commit 228aa2ab6aace295dcb531eccb1528d9edaca045
Author: Jiri Tomasek <email address hidden>
Date: Wed Oct 12 13:51:07 2016 +0200

    Ignore case in Node name validation regexp

    Closes-Bug: 1609917
    Closes-Bug: 1632631
    Change-Id: Ia298f9f99ce491ff5f963b0936db6ea97da06274

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/386199
Committed: https://git.openstack.org/cgit/openstack/tripleo-ui/commit/?id=68e6cfcc9032dbc7eacb56bbe941af03f2a880c3
Submitter: Jenkins
Branch: stable/newton

commit 68e6cfcc9032dbc7eacb56bbe941af03f2a880c3
Author: Jiri Tomasek <email address hidden>
Date: Wed Oct 12 13:51:07 2016 +0200

    Ignore case in Node name validation regexp

    Closes-Bug: 1609917
    Closes-Bug: 1632631
    Change-Id: Ia298f9f99ce491ff5f963b0936db6ea97da06274
    (cherry picked from commit 228aa2ab6aace295dcb531eccb1528d9edaca045)

[Dan Trainor (dtrainor)]

This still doesn't resolve the bug.

I am able to use a FQDN as the 'name' element in a json node definition that imports fine using 'openstack baremetal import --json stack.json' on the CLI, but uploading the file in the UI fails with the following error:

Name may only consist of RFC3986 unreserved characters, to wit: ALPHA / DIGIT / "-" / "." / "_" / "~"

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-ui 1.0.4 release.

[Jason E. Rist (jason-rist)]

Dan can you test again with the 1.0.4 release?

[Dan Trainor (dtrainor)]

Confirmed working in 1.0.4 release, thank you.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-ui 1.0.4 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-ui 2.0.0 release.