Juniper Openstack

[3.1 14] UI: Backtrace is displayed instead of error message when 'route' is left unfilled under Route aggregates

Bug #1609728 reported by Pavana
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R3.1
Fix Committed
Undecided
Siva Bavanasi
Juniper Openstack r3.1.0.0-fcs
Trunk
Fix Committed
Undecided
Siva Bavanasi
Juniper Openstack r3.2.0.0-fcs "r3.2.0.0"

Bug Description

1. Go to Configure > Networking > Routing > Route Aggregates
2. Click on create and enter the Name
3. Click to Add route but leave the field unfilled and click on save
Creation doesn't go through (expected) but a backtrace is displayed with the Error. We could instead give an appropriate error message.

Error: <pre>Traceback (most recent call last): File "/usr/lib/python2.7/dist-packages/vnc_cfg_api_server/vnc_cfg_api_server.py", line 522, in http_resource_create ok, result = stateful_create() File "/usr/lib/python2.7/dist-packages/vnc_cfg_api_server/vnc_cfg_api_server.py", line 491, in stateful_create db_conn) File "/usr/lib/python2.7/dist-packages/vnc_cfg_api_server/vnc_cfg_types.py", line 1966, in pre_dbe_create return cls._check(obj_dict, db_conn) File "/usr/lib/python2.7/dist-packages/vnc_cfg_api_server/vnc_cfg_types.py", line 1956, in _check route_family = IPNetwork(route).version File "/usr/lib/python2.7/dist-packages/netaddr/ip/__init__.py", line 923, in __init__ implicit_prefix, flags) File "/usr/lib/python2.7/dist-packages/netaddr/ip/__init__.py", line 818, in parse_ip_network raise TypeError('unexpected type %s for addr arg' % type(addr)) TypeError: unexpected type &lt;type 'NoneType'> for addr arg </pre>

Tags: ui
Revision history for this message
Pavana (pavanap) wrote :
information type: Proprietary → Public
Pavana (pavanap)
summary: - [3.1 14] UI: Need validation when a mandatory field is not filled
+ [3.1 14] UI: Backtrace is displayed instead of error message when
+ 'route' is left unfilled under Route aggregates
Rahul (rahuls)
Changed in juniperopenstack:
assignee: nobody → Siva Bavanasi (kbsiva)
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/22940
Submitter: Siva Bavanasi (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.1

Review in progress for https://review.opencontrail.org/22945
Submitter: Siva Bavanasi (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/22945
Committed: http://github.org/Juniper/contrail-web-controller/commit/c5f0d37b4491fa8c18972e515df869e73fde0b88
Submitter: Zuul
Branch: R3.1

commit c5f0d37b4491fa8c18972e515df869e73fde0b88
Author: Siva Kumar Bavanasi <email address hidden>
Date: Fri Aug 5 13:52:52 2016 +0530

Closes-bug: #1609728 - Backtrace is displayed instead of error message when
'route' is left unfilled under Route aggregates

UT Results: Web-Controller
PhantomJS 1.9.8 (Mac OS X 0.0.0): Executed 376 of 376 SUCCESS (2 mins 45.839
secs / 2 mins
35.515 secs)

Change-Id: I84e52e9088cf52b8565350b6cc31b7c09348c81b
(cherry picked from commit ee01294b8e56eb0ffaea8d422285efd5797603e5)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.1

Review in progress for https://review.opencontrail.org/22961
Submitter: Sachin Bansal (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/22962
Submitter: Sachin Bansal (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/22962
Committed: http://github.org/Juniper/contrail-controller/commit/b1abd776aa23d48c4df35c52fc0ee65e3abdc12d
Submitter: Zuul
Branch: master

commit b1abd776aa23d48c4df35c52fc0ee65e3abdc12d
Author: Sachin Bansal <email address hidden>
Date: Fri Aug 5 10:49:18 2016 -0700

Return appropriate error message when route prefix cannot be parsed

Change-Id: I5f518d661d916d7eff4b1857e7bd5a45e01f6094
Closes-Bug: 1609728
(cherry picked from commit f4466d7590038aadde0d480244c89b085db05807)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/22961
Committed: http://github.org/Juniper/contrail-controller/commit/f4466d7590038aadde0d480244c89b085db05807
Submitter: Zuul
Branch: R3.1

commit f4466d7590038aadde0d480244c89b085db05807
Author: Sachin Bansal <email address hidden>
Date: Fri Aug 5 10:49:18 2016 -0700

Return appropriate error message when route prefix cannot be parsed

Change-Id: I5f518d661d916d7eff4b1857e7bd5a45e01f6094
Closes-Bug: 1609728

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/22940
Submitter: Siva Bavanasi (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/22940
Committed: http://github.org/Juniper/contrail-web-controller/commit/686f56d4652643aabc98227e88d28feb584934a4
Submitter: Zuul
Branch: master

commit 686f56d4652643aabc98227e88d28feb584934a4
Author: Siva Kumar Bavanasi <email address hidden>
Date: Fri Aug 5 13:52:52 2016 +0530

Closes-bug: #1609728 - Backtrace is displayed instead of error message when
'route' is left unfilled under Route aggregates

Change-Id: I84e52e9088cf52b8565350b6cc31b7c09348c81b

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.