The is_plugin_active() function can give false positives
Bug #1609112 reported by
Robert Lyon
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Fix Released
|
High
|
Robert Lyon | ||
15.04 |
Fix Released
|
High
|
Unassigned | ||
15.10 |
Fix Released
|
High
|
Unassigned | ||
16.04 |
Fix Released
|
High
|
Unassigned | ||
16.10 |
Fix Released
|
High
|
Robert Lyon |
Bug Description
This is due to the fact that we have different plugin types with the same name, eg:
Artefact | Blocktype
-------
blog | blog
comment | comment
annotation | annotation
And that we check the type 'artefact' first so in the case of the Artefact 'annotation' being active but the blocktype 'annotation' not being active we will get 'true' from is_plugin_active()
We need to alter the function and pass it a 'type' so we can indicate which of the types we are interested in.
I'll mark this as 'high' as this could lead to confusion in the use of the function.
Changed in mahara: | |
milestone: | 16.10.0 → none |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Patch for "master" branch: https:/ /reviews. mahara. org/6786