[fuel-devops] revert-resume action of dos.py throws exception when tries to reach admin node

Bug #1609006 reported by Dmitry Tyzhnenko
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
Medium
Dmitry Belyaninov
Mitaka
Fix Committed
Medium
Dmitry Belyaninov

Bug Description

When fuel-devops tries revert and resume a environment without the admin node, execution finished by exception

Expected result:

Do nothing if environment doesn't have the admin node.

Actual result:

$ dos.py revert-resume fuel-ccp k8s_deployed
2016-08-02 15:35:58 - INFO - libvirt_driver.py:1463 -- Revert node-1 (paused) to internal snapshot k8s_deployed
2016-08-02 15:36:07 - INFO - libvirt_driver.py:1463 -- Revert node-2 (paused) to internal snapshot k8s_deployed
2016-08-02 15:36:16 - INFO - libvirt_driver.py:1463 -- Revert node-3 (paused) to internal snapshot k8s_deployed
2016-08-02 15:36:23 - INFO - libvirt_driver.py:1463 -- Revert node-4 (paused) to internal snapshot k8s_deployed
2016-08-02 15:36:31 - INFO - libvirt_driver.py:1463 -- Revert node-5 (paused) to internal snapshot k8s_deployed
Time synchronization is starting
Traceback (most recent call last):
  File "/home/dtyzhnenko/devops-venv/bin/dos.py", line 6, in <module>
    exec(compile(open(__file__).read(), __file__, 'exec'))
  File "/home/dtyzhnenko/workspace/fuel/fuel-devops/bin/dos.py", line 22, in <module>
    main()
  File "/home/dtyzhnenko/workspace/fuel/fuel-devops/devops/shell.py", line 630, in main
    Shell(args).execute()
  File "/home/dtyzhnenko/workspace/fuel/fuel-devops/devops/shell.py", line 55, in execute
    self.commands.get(self.params.command)(self)
  File "/home/dtyzhnenko/workspace/fuel/fuel-devops/devops/shell.py", line 179, in do_revert_resume
    self.do_timesync()
  File "/home/dtyzhnenko/workspace/fuel/fuel-devops/devops/shell.py", line 164, in do_timesync
    cur_time = sync_time(self.env, nodes, skip_sync=True)
  File "/home/dtyzhnenko/workspace/fuel/fuel-devops/devops/helpers/retry.py", line 56, in wrapper
    return func(*args, **kwargs)
  File "/home/dtyzhnenko/workspace/fuel/fuel-devops/devops/helpers/ntp.py", line 37, in sync_time
    with GroupNtpSync(env, node_names) as g_ntp:
  File "/home/dtyzhnenko/workspace/fuel/fuel-devops/devops/helpers/ntp.py", line 294, in __init__
    remote = get_node_remote(env, node_name)
  File "/home/dtyzhnenko/workspace/fuel/fuel-devops/devops/helpers/helpers.py", line 204, in get_node_remote
    name=node_name).interfaces[0].mac_address)
  File "/home/dtyzhnenko/workspace/fuel/fuel-devops/devops/helpers/helpers.py", line 235, in get_slave_ip
    admin_ip = get_admin_ip(env)
  File "/home/dtyzhnenko/workspace/fuel/fuel-devops/devops/helpers/helpers.py", line 216, in get_admin_ip
    return env.get_node(name='admin').get_ip_address_by_network_name('admin')
  File "/home/dtyzhnenko/workspace/fuel/fuel-devops/devops/models/environment.py", line 519, in get_node
    raise DevopsObjNotFound(Node, *args, **kwargs)
devops.error.DevopsObjNotFound: devops.models.node.Node(name='admin') does not exist in database.

Changed in fuel:
milestone: 9.1 → 9.2
Changed in fuel:
status: New → Confirmed
Changed in fuel:
assignee: Fuel QA Team (fuel-qa) → Dmitry Belyaninov (dbelyaninov)
Roman Vyalov (r0mikiam)
Changed in fuel:
status: Confirmed → Won't Fix
Revision history for this message
Dmitry Belyaninov (dbelyaninov) wrote :

The issue can't be fixed on devops 2.9

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-devops (master)

Fix proposed to branch: master
Review: https://review.openstack.org/435418

Changed in fuel:
status: Won't Fix → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-devops (master)

Reviewed: https://review.openstack.org/435418
Committed: https://git.openstack.org/cgit/openstack/fuel-devops/commit/?id=891559577e19793d319cde370cbcc4ab62c50b79
Submitter: Jenkins
Branch: master

commit 891559577e19793d319cde370cbcc4ab62c50b79
Author: Dmitry Belyaninov <email address hidden>
Date: Fri Feb 17 12:26:25 2017 +0000

    Discard time-sync for some envs

    If env is not Fuel, we can't know slaves IPs,
    that is why we should not start time-sync procedure.

    Change-Id: I15770841ee1c886544cc734ee1ff1674ce2aa3af
    Closes-Bug: 1609006

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-devops (release/2.9)

Fix proposed to branch: release/2.9
Review: https://review.openstack.org/438937

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-devops (release/2.9)

Reviewed: https://review.openstack.org/438937
Committed: https://git.openstack.org/cgit/openstack/fuel-devops/commit/?id=2e407f65648efb087d95f777c571ac79e45a4f87
Submitter: Jenkins
Branch: release/2.9

commit 2e407f65648efb087d95f777c571ac79e45a4f87
Author: Dmitry Belyaninov <email address hidden>
Date: Tue Feb 28 12:08:08 2017 +0000

    Discard time-sync for some envs

    If env is not Fuel, we can't know slaves IPs,
    that is why we should not start time-sync procedure.

    Change-Id: I15770841ee1c886544cc734ee1ff1674ce2aa3af
    Closes-Bug: 1609006

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.