Policy service caching does not work within hz-dynamic-table

Bug #1608623 reported by Travis Tripp
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
High
Travis Tripp

Bug Description

The policy service caching (where it ensures that if you look up the same policy more than once) does not seem to work under hz-dynamic-table.

Turn on ng-images which recently migrated to hz-dynamic-table and watch the network calls. You'll note a bunch of policy calls and if you look at the request body, you'll see the same rules going in multiple times.

http://imgur.com/a/Sh4fj

Changed in horizon:
assignee: nobody → Travis Tripp (travis-tripp)
Changed in horizon:
status: New → In Progress
Changed in horizon:
milestone: none → newton-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/349594
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=deda07c4c35c1bc5a80a76c0e8041a8a4bd57874
Submitter: Jenkins
Branch: master

commit deda07c4c35c1bc5a80a76c0e8041a8a4bd57874
Author: Travis Tripp <email address hidden>
Date: Fri Jul 8 17:04:31 2016 -0600

    Memoize policy service

    There is a hole in the policy service caching layer
    that has something to do with ng-repeat. The angular
    http cache service doesn't seem to work within a single
    digest cycle or something... so I simplfied and
    improved performance by using memoize to
    prevent redundant checks which were happening in
    hz-dynamic-table.

    See bug for details on verifying this manually.

    Change-Id: Ib0b3a806d1c6b065e20cb22b8255048bd836dd1b
    Closes-Bug: 1608623

Changed in horizon:
status: In Progress → Fix Released
Changed in horizon:
importance: Undecided → High
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/horizon 10.0.0.0b3

This issue was fixed in the openstack/horizon 10.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.