Policy service caching does not work within hz-dynamic-table
Bug #1608623 reported by
Travis Tripp
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Dashboard (Horizon) |
Fix Released
|
High
|
Travis Tripp |
Bug Description
The policy service caching (where it ensures that if you look up the same policy more than once) does not seem to work under hz-dynamic-table.
Turn on ng-images which recently migrated to hz-dynamic-table and watch the network calls. You'll note a bunch of policy calls and if you look at the request body, you'll see the same rules going in multiple times.
Changed in horizon: | |
assignee: | nobody → Travis Tripp (travis-tripp) |
Changed in horizon: | |
status: | New → In Progress |
Changed in horizon: | |
milestone: | none → newton-3 |
Changed in horizon: | |
importance: | Undecided → High |
To post a comment you must log in.
Reviewed: https:/ /review. openstack. org/349594 /git.openstack. org/cgit/ openstack/ horizon/ commit/ ?id=deda07c4c35 c1bc5a80a76c0e8 041a8a4bd57874
Committed: https:/
Submitter: Jenkins
Branch: master
commit deda07c4c35c1bc 5a80a76c0e8041a 8a4bd57874
Author: Travis Tripp <email address hidden>
Date: Fri Jul 8 17:04:31 2016 -0600
Memoize policy service
There is a hole in the policy service caching layer dynamic- table.
that has something to do with ng-repeat. The angular
http cache service doesn't seem to work within a single
digest cycle or something... so I simplfied and
improved performance by using memoize to
prevent redundant checks which were happening in
hz-
See bug for details on verifying this manually.
Change-Id: Ib0b3a806d1c6b0 65e20cb22b82550 48bd836dd1b
Closes-Bug: 1608623