[qos]: Scaling limits of FC are not met

[Pulkit Tandon]

Build 6 R3.1 -Kilo
Ubuntu 14.04

Configured 256 Forwarding classes.
All got configured though config.
(In presence of a default-forwarding-class, ideally 255 FCs should have been configured but it allowed all 256. Total 257 FCs can been seen)

Configured 1 more FC and expected the config to give an error.(Assuming it is not counting default-FC)
The configuration passed and I could see total 258 Forwarding classes in config node as well as UI.

On Vroter node, I could see only 128 entries using cos-map:
root@nodeg31:~# qosmap --dump-fc
Forwarding Class Map 0
 FC DSCP EXP .1p Queue
  0 12 0 0 0
  1 1 0 0 0
  2 2 0 0 0
  3 3 0 0 0
  4 4 0 0 0
  5 5 0 0 0
  6 6 0 0 0
  7 7 0 0 0
  8 8 0 0 0
  9 9 0 0 0
 10 10 0 0 0
 11 11 0 0 0
 12 12 0 0 0
 13 13 0 0 0
 14 14 0 0 0
 15 15 0 0 0
 16 16 0 0 0
 17 17 0 0 0
 18 18 0 0 0
 19 19 0 0 0
 20 20 0 0 0
 21 21 0 0 0
 22 22 0 0 0
 23 23 0 0 0
 24 24 0 0 0
 25 25 0 0 0
 26 26 0 0 0
 27 27 0 0 0
 28 28 0 0 0
 29 29 0 0 0
 30 30 0 0 0
 31 31 0 0 0
 32 32 0 0 0
 33 33 0 0 0
 34 34 0 0 0
 35 35 0 0 0
 36 36 0 0 0
 37 37 0 0 0
 38 38 0 0 0
 39 39 0 0 0
 40 40 0 0 0
 41 41 0 0 0
 42 42 0 0 0
 43 43 0 0 0
 44 44 0 0 0
 45 45 0 0 0
 46 46 0 0 0
 47 47 0 0 0
 48 48 0 0 0
 49 49 0 0 0
 50 50 0 0 0
 51 51 0 0 0
 52 52 0 0 0
 53 53 0 0 0
 54 54 0 0 0
 55 55 0 0 0
 56 56 0 0 0
 57 57 0 0 0
 58 58 0 0 0
 59 59 0 0 0
 60 60 0 0 0
 61 61 0 0 0
 62 62 0 0 0
 63 63 0 0 0
 64 0 1 1 0
 65 1 1 1 0
 66 2 1 1 0
 67 3 1 1 0
 68 4 1 1 0
 69 5 1 1 0
 70 6 1 1 0
 71 7 1 1 0
 72 8 1 1 0
 73 9 1 1 0
 74 10 1 1 0
 75 11 1 1 0
 76 12 1 1 0
 77 13 1 1 0
 78 14 1 1 0
 79 15 1 1 0
 80 16 1 1 0
 81 17 1 1 0
 82 18 1 1 0
 83 19 1 1 0
 84 20 1 1 0
 85 21 1 1 0
 86 22 1 1 0
 87 23 1 1 0
 88 24 1 1 0
 89 25 1 1 0
 90 26 1 1 0
 91 27 1 1 0
 92 28 1 1 0
 93 29 1 1 0
 94 30 1 1 0
 95 31 1 1 0
 96 32 1 1 0
 97 33 1 1 0
 98 34 1 1 0
 99 35 1 1 0
100 36 1 1 0
101 37 1 1 0
102 38 1 1 0
103 39 1 1 0
104 40 1 1 0
105 41 1 1 0
106 42 1 1 0
107 43 1 1 0
108 44 1 1 0
109 45 1 1 0
110 46 1 1 0
111 47 1 1 0
112 48 1 1 0
113 49 1 1 0
114 50 1 1 0
115 51 1 1 0
116 52 1 1 0
117 53 1 1 0
118 54 1 1 0
119 55 1 1 0
120 56 1 1 0
121 57 1 1 0
122 58 1 1 0
123 59 1 1 0
124 60 1 1 0
125 61 1 1 0
126 62 1 1 0
127 63 1 1 0
root@nodeg31:~#

In vrouter introspect page, I can see all 258 entries:

Pagination
req more
prev_page
next_page
begin:100,end:199,table:db.forwardingclass.0,
first_page
begin:0,end:99,table:db.forwardingclass.0,
all
begin:-1,end:-1,table:db.forwardingclass.0,
table_size
258
entries
0-99/258
false

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/22768
Submitter: Naveen N (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/22768
Committed: http://github.org/Juniper/contrail-controller/commit/dea1c7ee522283891754ca699e85740e8e322573
Submitter: Zuul
Branch: R3.1

commit dea1c7ee522283891754ca699e85740e8e322573
Author: Naveen N <email address hidden>
Date: Tue Aug 2 23:39:47 2016 +0530

* Pass forwarding class as int16_t as specified in sandesh file

Change-Id: Ifbf462a1f39390847ed3999612498d12b991b70a
Closes-bug:#1608392

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/22925
Submitter: Naveen N (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/22925
Committed: http://github.org/Juniper/contrail-controller/commit/c9ede4d69115dd2cddabd93c9a17ac74addb3813
Submitter: Zuul
Branch: master

commit c9ede4d69115dd2cddabd93c9a17ac74addb3813
Author: Naveen N <email address hidden>
Date: Tue Aug 2 23:39:47 2016 +0530

* Pass forwarding class as int16_t as specified in sandesh file

Change-Id: Ifbf462a1f39390847ed3999612498d12b991b70a
Closes-bug:#1608392

[Pulkit Tandon (pulkitt)]

Tested on R3.1 - Build 25
It was working on that build.
Hence marking it fixed