many tests directly modify RESOURCE_ATTRIBUTES_MAP and leave it modified

Bug #1607979 reported by Isaku Yamahata
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Won't Fix
Undecided
Isaku Yamahata

Bug Description

many tests directly modify the global variable, RESOURCE_ATTRIBUTES_MAP and leave it modified.

As a result, the value isn't predictable. So the test result can be non-deterministic depending on the execution order.
Especially the result can be different when only the test is run and when it's run as whole.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/349111

Changed in neutron:
assignee: nobody → Isaku Yamahata (yamahata)
status: New → In Progress
Revision history for this message
Isaku Yamahata (yamahata) wrote : Re: many tests directly modify RESOURCE_ATTRIBUTES_MAP

The patch unveiled soo many unit tests are broken.
 - Failed: 1792
Sigh.

summary: - many tests directly modify RESOURCE_ATTRIBUTES_MAP
+ many tests directly modify RESOURCE_ATTRIBUTES_MAP and leave it modified
Revision history for this message
Armando Migliaccio (armando-migliaccio) wrote :

I don't understand: why would a test care about the RESOURCE_ATTRIBUTES_MAP?

Changed in neutron:
status: In Progress → Incomplete
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by Isaku Yamahata (<email address hidden>) on branch: master
Review: https://review.openstack.org/349111

Changed in neutron:
status: Incomplete → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.