Schema for enabling users breaks keystoneclient and other projects

Bug #1607751 reported by Boris Bobrov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
High
Boris Bobrov
python-keystoneclient
Fix Released
Medium
Boris Bobrov

Bug Description

Patch https://review.openstack.org/#/c/344057/ introduced schema validation for enabling a user. In the schema, it forbid passing any parameters other than "enabled". It causes failures to at least rally: http://logs.openstack.org/88/348788/1/check/gate-rally-dsvm-keystone-v2api-rally/992e7ee/rally-plot/results.html.gz#/KeystoneBasic.create_user_set_enabled_and_delete/failures

It happens because keystoneclient passes "id" and "enabled": https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/v2_0/users.py#L60-L62 , so the change broke anybody who uses the method in keystoneclient.

Changed in keystone:
importance: Undecided → High
Changed in python-keystoneclient:
importance: Undecided → Medium
Changed in keystone:
assignee: nobody → Boris Bobrov (bbobrov)
Changed in python-keystoneclient:
assignee: nobody → Boris Bobrov (bbobrov)
Changed in keystone:
milestone: none → newton-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/348851

Changed in keystone:
status: New → In Progress
Changed in python-keystoneclient:
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-keystoneclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/348881

Changed in python-keystoneclient:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/348851
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=6a94b28281f8477727314ed1eefd2fb252ee1a31
Submitter: Jenkins
Branch: master

commit 6a94b28281f8477727314ed1eefd2fb252ee1a31
Author: Boris Bobrov <email address hidden>
Date: Fri Jul 29 14:41:41 2016 +0300

    Allow attributes other than `enabled` in schema

    Although it is not needed, keystoneclient passed `id` in the payload.
    For compatibility with it (and with other clients) we have to allow
    passing other attributes.

    Change-Id: I997d55de28825921ed33646a9ee5cf494b089aba
    Closes-Bug: 1607751

Changed in keystone:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-keystoneclient (master)

Reviewed: https://review.openstack.org/348881
Committed: https://git.openstack.org/cgit/openstack/python-keystoneclient/commit/?id=2b3258dcd0581e3a1291bd0e9277698b5631dced
Submitter: Jenkins
Branch: master

commit 2b3258dcd0581e3a1291bd0e9277698b5631dced
Author: Boris Bobrov <email address hidden>
Date: Fri Jul 29 16:17:44 2016 +0300

    Do not send user ids as payload

    User ids are already in the URL. Keystone doesn't consume ids in the
    body.

    Change-Id: Ie90ebd32fe584dd1b360dc75a828316b1a9aedde
    Closes-Bug: 1607751

Changed in python-keystoneclient:
status: In Progress → Fix Released
Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/python-keystoneclient 3.5.0

This issue was fixed in the openstack/python-keystoneclient 3.5.0 release.

Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/keystone 10.0.0.0b3

This issue was fixed in the openstack/keystone 10.0.0.0b3 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-keystoneclient 3.5.0

This issue was fixed in the openstack/python-keystoneclient 3.5.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.