Crash on 0.92.x on file open

[Jabiertxof]

Inkscape 0.92.x crash on open file dialog if enable preview is on.
Debian stretch r15024
Atached backtrace.
Steps to reproduce.
File open, crash on dialog.run().
Workarround, while is fixed you can use trunk or 0.91 and set the preview value stored in prefs to off usinf the same file dialog that crash, or edit prefs file and put in save_as, save_copy_open and import this: enable_preview="0"

[su_v (suv-lp)]

See also Bug #1571192, comment 12 - this probably should be considered as critical and one of the release blockers for 0.92.

[su_v (suv-lp)]

As mentioned earlier in reply to tweenk's request for tests in bug #1571192: reproduced on OS X 10.7.5 with GTK+/X11 2.24.29 and GTK+/Quartz 2.24.30.

This regression was introduced in lp:inkscape/0.92.x r15024 which reverted (parts of) the canvas refactoring from the hackfest 2016.

[jazzynico (jazzynico)]

Also reproduced on Windows XP (32-bit) with 0.92.x rev. 15025, with GTK dialogs selected in the preferences.
Not reproduced with native dialogs and with trunk rev. 15028.

[Jabiertxof (jabiertxof)]

The bug happends if preview widget is active.

[su_v (suv-lp)]

<opinion>
Hopefully the workaround which disables an important feature to preview files before fully loading them (committed in lp:inkscape/0.92.x r15028) is not (silently) accepted as “fix” and stays as-is in the upcoming stable release.

Likely a solution to fix the crash is already in trunk's commit history: the same crash was exposed briefly while the refactoring was on-going during the hackfest.
</opinion>

[Jabiertxof (jabiertxof)]

I commit this to get a usable version of "trunk" code to allow start with the migration trunk to GTK3 this week with Alex merge. Of curse this hack need to be removed and the bug fixed before the launch of 0.92.

[su_v (suv-lp)]

On 2016-08-03 22:49 (+0200), Jabiertxof wrote:
> I commit this to get a usable version of "trunk" code (...)

With bug #1608152 unfixed the stable release branch is still unusable - and to avoid the crash with previews in file dialogs, no code changes would have been necessary (developers or the one or two users experimenting with current “stable” release branch builds could have changed the prefs setting for previews either manually, or with a working build (trunk, 0.91)).

<opinion>
Hiding critical issues has the inherent risk to prevent a real fix (because the issue is no longer exposed).
</opinion>

[Jabiertxof (jabiertxof)]

You are Ok, Im trying a real fix and if couldent revert it back tomorrow.

[su_v (suv-lp)]

Based on archived trunk builds [1] before and during the hackfest:
- not reproduced with rev <= 14783
- crash reproduced with rev 14790, 14792, 14793
- partially reproduced with
  rev 14795 (empty preview)
  rev 14800, 14804, 14808, 14815 (preview area is black)
- no crash, correct preview with rev >= 14817

[1] autotools-based builds on OS X 10.7.5, using GTK+/X11 2.24.29

[jazzynico (jazzynico)]

Seems to be fixed with the patch attached in bug #1608216 "Crash when resizing the application window", comment #8.
Please test!

[su_v (suv-lp)]

Patch [1] tested successfully with lp:inkscape/0.92.x r15024, r15043, GTK+/X11 2.24.29 (on OS X 10.7.5): previews in the Gtk file chooser dialog no longer trigger a crash with patched builds.

Not tested for unintended side-effects possibly exposed elsewhere.
--
[1] https://bugs.launchpad.net/inkscape/+bug/1608216/+attachment/4723363/+files/1608216-CrashResizing.diff

[jazzynico (jazzynico)]

Tested successfully on Xubuntu 16.04 and committed rev. 15044.