[fuel-qa] Yum don't clear all octane data

[Sergey Abramov]

'yum remove fuel-octane' command does not actually remove octane files. It produces issues while testing - e.g. reinstallation of octane for applying patches can fails.

Steps to repro:
yum install fuel-octane
yum remove fuel-octane
ls /usr/lib/python2.7/site-packages/octane

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/7.0
Review: https://review.openstack.org/348783

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/348784

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/348785

[Ilya Kharin (akscram)]

@Sergey, could you explain the moment 'yum remove' does not remove some files that were installed by the provided RPM-package? You can check the exact list of files that were installed by the package:

    rpm -ql fuel-octane

Or 'yum remove' does not remove files that were not presented in the package?

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/348785
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=c999ab83fd05cda6b8d036100cb539c2a203b78b
Submitter: Jenkins
Branch: master

commit c999ab83fd05cda6b8d036100cb539c2a203b78b
Author: Sergey Abramov <email address hidden>
Date: Tue Jul 26 03:47:03 2016 +0300

    Remove octane direcotry after yum remove

    Related-Bug: 1607682
    Change-Id: I3e919ecf6d2306f742347bbc9e2eefd1fbafd8f3

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/348784
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=7cbccd90728e45bb84970be9e50202cb86dfa316
Submitter: Jenkins
Branch: stable/mitaka

commit 7cbccd90728e45bb84970be9e50202cb86dfa316
Author: Sergey Abramov <email address hidden>
Date: Tue Jul 26 03:47:03 2016 +0300

    Remove octane direcotry after yum remove

    Related-Bug: 1607682
    Change-Id: I3e919ecf6d2306f742347bbc9e2eefd1fbafd8f3

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/347087
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=6d0175a5d4ce00ac2a9b527fba1f84635615657d
Submitter: Jenkins
Branch: stable/8.0

commit 6d0175a5d4ce00ac2a9b527fba1f84635615657d
Author: Sergey Abramov <email address hidden>
Date: Tue Jul 26 03:47:03 2016 +0300

    Remove octane direcotry after yum remove

    Related-Bug: 1607682
    Change-Id: I3e919ecf6d2306f742347bbc9e2eefd1fbafd8f3

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/348783
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=b0ed55bad1c8f903a6575cf38202c78bdfb26e2b
Submitter: Jenkins
Branch: stable/7.0

commit b0ed55bad1c8f903a6575cf38202c78bdfb26e2b
Author: Sergey Abramov <email address hidden>
Date: Tue Jul 26 03:47:03 2016 +0300

    Remove octane direcotry after yum remove

    Related-Bug: 1607682
    Change-Id: I3e919ecf6d2306f742347bbc9e2eefd1fbafd8f3

[Roman Prykhodchenko (romcheg)]

Please triage this bug properly or close it, if it's no longer valid.

[Sergey Abramov (sabramov)]

We have problem

At first install fuel-octane
after that patch octane that add file to it (just for test `touch /usr/lib/python2.7/site-packages/octane/commands/crazy_cmd.py`)
after that remove octane
and than

find /usr/lib/python2.7/site-packages/octane | grep crazy_cmd
/usr/lib/python2.7/site-packages/octane/commands/crazy_cmd.py

Why this is the problem?
CI working this way:
in every step it reverts to snapshot with previous finished procedure,
removes octane,
install new and
patches it.
If in previous step octane had been already patched, this file had been added, it would not patched on the next step.

This problem fixed by workaround in fuel-qa.

[Ilya Kharin (akscram)]

RPM packages remove only files, declared in the %files section, they are responsible for. They will not remove files out of this list. It means that your example with crazy_cmd is not valid.

[Ilya Kharin (akscram)]

Okay then, we have such workaround for fuel-qa that handles some custom patches that are applied on octane.