Cron packages missing for 'source' install type

[Blake Caldwell]

The changes to the cron dockerfile template in the following commit doesn't handle the 'source' install type.

----
commit 9ad412a41810f20e24a3da19f7c1bbf5fdcc96d1
Author: Abe Music <email address hidden>
Date: Mon Jul 25 08:58:26 2016 -0500

    Customizations for cron

    This patchset contains customization of Dockerfile
    of cron container

    Change-Id: I7066b281d2a546e52ab0fdc2722da2e0026fc3a7
    Partially-implements: blueprint third-party-plugin-support
----

For this container, there should be no difference between 'binary' and 'source'. Propose the following patch:

----
diff --git a/docker/cron/Dockerfile.j2 b/docker/cron/Dockerfile.j2
index b0d7965..fa8f771 100644
--- a/docker/cron/Dockerfile.j2
+++ b/docker/cron/Dockerfile.j2
@@ -2,7 +2,6 @@ FROM {{ namespace }}/{{ image_prefix }}base:{{ tag }}
 MAINTAINER {{ maintainer }}
 {% import "macros.j2" as macros with context %}

-{% if install_type == 'binary' %}
     {% if base_distro in ['centos', 'fedora', 'oraclelinux', 'rhel'] %}
         {% set cron_packages = [
             'cronie',
@@ -16,7 +15,6 @@ MAINTAINER {{ maintainer }}
     {% endif %}

 RUN {{ macros.install_packages(cron_packages | customizable("packages")) }}
-{% endif %}

 COPY extend_start.sh /usr/local/bin/kolla_extend_start
 RUN chmod 755 /usr/local/bin/kolla_extend_start
----

[Eduardo Gonzalez (egonzalez90)]

Fixed with https://review.openstack.org/#/c/348270/

Duplicated bug https://bugs.launchpad.net/kolla/+bug/1607336