device_id doesn't work with other filters for port-list

Bug #1607584 reported by Tony Liu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R3.0.3.x
Fix Committed
Medium
Édouard Thuleau
R3.1
Fix Committed
Medium
Édouard Thuleau
Trunk
Fix Committed
Medium
Édouard Thuleau

Bug Description

For port-list, if filter device_id is present, other filters won't work.
For example,
neutron port-list --device_id <device ID> --network_id <network ID>
will list all ports with device ID, filter network_id has no effect.

If filter device_id is not present, other filters work fine.
For example,
neutron port-list --network_id <network ID> --fixed_ips ip_address=<IP address>
works as expected, both filters have effect.

Tags: config
Sachin Bansal (sbansal)
Changed in juniperopenstack:
assignee: nobody → Sachin Bansal (sbansal)
Sachin Bansal (sbansal)
Changed in juniperopenstack:
assignee: Sachin Bansal (sbansal) → Édouard Thuleau (ethuleau)
Nischal Sheth (nsheth)
tags: added: config
information type: Proprietary → Public
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/22957
Submitter: ?douard Thuleau (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.1

Review in progress for https://review.opencontrail.org/23031
Submitter: ?douard Thuleau (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/22957
Submitter: ?douard Thuleau (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/22957
Committed: http://github.org/Juniper/contrail-controller/commit/72c9434b65d037858cf319064d519db3e578fd52
Submitter: Zuul
Branch: master

commit 72c9434b65d037858cf319064d519db3e578fd52
Author: Édouard Thuleau <email address hidden>
Date: Fri Aug 5 17:34:13 2016 +0200

[VNC OpenStack] In port list, apply filters even device_ids filter is defined

Divide the port list in two cases:
- if device_ids filter: list vmis filtered by ids and [back-]referenced by
device_ids then filter that list with project if necessary
- if no device_ids filter: list vmis filtered by ids and project owner.

After that, the list of vnc vmi objects is transformed to a list of
neutron port dicts where last filters (network, device_owner, name and
fixed_ips) are applied.

Change-Id: I840361304da4a69b819216ceda892519f1b4fddc
Closes-Bug: #1607584

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/23249
Submitter: ?douard Thuleau (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.1

Review in progress for https://review.opencontrail.org/23031
Submitter: ?douard Thuleau (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/23249
Submitter: ?douard Thuleau (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/23249
Committed: http://github.org/Juniper/contrail-controller/commit/697188e30d9b2f4dd73c47cc9412915a01f78765
Submitter: Zuul
Branch: master

commit 697188e30d9b2f4dd73c47cc9412915a01f78765
Author: Édouard Thuleau <email address hidden>
Date: Fri Aug 12 10:31:27 2016 +0200

[VNC OpenStack] Improve port list

When list port with filter device ids through the neutron api, the
device ids can be a contrail virtual machine interface or logical router
id. That patch only lists logical routers if all device ids was not
already founded in virtual machine interfaces.

Change-Id: I022806b9b996fe55f078887929ef3208d66ae36a
Closes-bug: #1607584

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/23031
Committed: http://github.org/Juniper/contrail-controller/commit/701dbb73e109e95f049355542b8faf8b06a2967a
Submitter: Zuul
Branch: R3.1

commit 701dbb73e109e95f049355542b8faf8b06a2967a
Author: Édouard Thuleau <email address hidden>
Date: Fri Aug 5 17:34:13 2016 +0200

[VNC OpenStack] In port list, apply filters even device_ids filter is defined

Divide the port list in two cases:
- if device_ids filter: list vmis filtered by ids and [back-]referenced by
device_ids then filter that list with project if necessary
- if no device_ids filter: list vmis filtered by ids and project owner.

After that, the list of vnc vmi objects is transformed to a list of
neutron port dicts where last filters (network, device_owner, name and
fixed_ips) are applied.

Change-Id: I840361304da4a69b819216ceda892519f1b4fddc
Closes-Bug: #1607584
(cherry picked from commit 72c9434b65d037858cf319064d519db3e578fd52)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.1

Review in progress for https://review.opencontrail.org/25377
Submitter: Martin Millnert (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/25377
Committed: http://github.org/Juniper/contrail-controller/commit/4e8d03608c7d62a2e4b1a064adfa7c7ac013a3a7
Submitter: Zuul
Branch: R3.1

commit 4e8d03608c7d62a2e4b1a064adfa7c7ac013a3a7
Author: Édouard Thuleau <email address hidden>
Date: Fri Aug 12 10:31:27 2016 +0200

[VNC OpenStack] Improve port list

When list port with filter device ids through the neutron api, the
device ids can be a contrail virtual machine interface or logical router
id. That patch only lists logical routers if all device ids was not
already founded in virtual machine interfaces.

Backporting note:
The exact commit needed a merge conflict resolution due to conflict with
daaa95130.

Change-Id: I022806b9b996fe55f078887929ef3208d66ae36a
Closes-bug: #1607584
Signed-off-by: Martin Millnert <email address hidden>

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.0.3.x

Review in progress for https://review.opencontrail.org/32912
Submitter: ?douard Thuleau (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/32913
Submitter: ?douard Thuleau (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/32912
Committed: http://github.com/Juniper/contrail-controller/commit/a484fc1ee61c3f98274681f96be219e9aef05994
Submitter: Zuul (<email address hidden>)
Branch: R3.0.3.x

commit a484fc1ee61c3f98274681f96be219e9aef05994
Author: Édouard Thuleau <email address hidden>
Date: Fri Aug 5 17:34:13 2016 +0200

[VNC OpenStack] In port list, apply filters even device_ids filter is defined

Divide the port list in two cases:
- if device_ids filter: list vmis filtered by ids and [back-]referenced by
device_ids then filter that list with project if necessary
- if no device_ids filter: list vmis filtered by ids and project owner.

After that, the list of vnc vmi objects is transformed to a list of
neutron port dicts where last filters (network, device_owner, name and
fixed_ips) are applied.

Change-Id: I840361304da4a69b819216ceda892519f1b4fddc
Closes-Bug: #1607584
(cherry picked from commit 72c9434b65d037858cf319064d519db3e578fd52)
(cherry picked from commit 701dbb73e109e95f049355542b8faf8b06a2967a)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/32913
Committed: http://github.com/Juniper/contrail-controller/commit/4ef130f1109ac2f980cd74cb8bfb0cdb884ae302
Submitter: Zuul (<email address hidden>)
Branch: R3.0.3.x

commit 4ef130f1109ac2f980cd74cb8bfb0cdb884ae302
Author: Édouard Thuleau <email address hidden>
Date: Fri Aug 12 10:31:27 2016 +0200

[VNC OpenStack] Improve port list

When list port with filter device ids through the neutron api, the
device ids can be a contrail virtual machine interface or logical router
id. That patch only lists logical routers if all device ids was not
already founded in virtual machine interfaces.

Backporting note:
The exact commit needed a merge conflict resolution due to conflict with
daaa95130.

Change-Id: I022806b9b996fe55f078887929ef3208d66ae36a
Closes-bug: #1607584
Signed-off-by: Martin Millnert <email address hidden>
(cherry picked from commit 4e8d03608c7d62a2e4b1a064adfa7c7ac013a3a7)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.