storm plugin fails to scale

[Telles Mota Vidal Nóbrega]

Storm plugin fails cluster scaling due to hardcoded outdated zookeeper path.

if need_zookeeper_update:
            zk_path = '/opt/zookeeper/zookeeper-3.4.6/conf/zoo.cfg'
            files_zookeeper = {zk_path: ng_extra['zk_conf']}
            self._push_zk_configs(r, files_zookeeper)

This needs to be changed to /opt/zookeeper/zookeeper/conf/zoo.cfg.

Problem was found on scenarios tests, log below.

Captured stdout:
~~~~~~~~~~~~~~~~
    All tests for Cinder were skipped
    Results of testing plugin storm 1.0.1
    +-----------------------------+--------+-------------+
    | Check | Status | Duration, s |
    +-----------------------------+--------+-------------+
    | Create node group templates | OK | 1 |
    | Set flavor | OK | 0 |
    | Set flavor | OK | 0 |
    | Set flavor | OK | 0 |
    | Create cluster template | OK | 1 |
    | Create cluster | OK | 6 |
    | Check cluster state | OK | 169 |
    | Check cinder volumes | OK | 0 |
    | Check event logs | OK | 0 |
    | Cluster scaling | FAILED | 117 |
    +-----------------------------+--------+-------------+

Captured stderr:
~~~~~~~~~~~~~~~~
    Traceback (most recent call last):

      File "/home/jenkins/workspace/gate-sahara_tests-storm_1.0.1-u14-aio/sahara_tests/scenario/base.py", line 59, in wrapper
        return fct(self, *args, **kwargs)

      File "/home/jenkins/workspace/gate-sahara_tests-storm_1.0.1-u14-aio/sahara_tests/scenario/base.py", line 449, in check_scale
        self._poll_cluster_status(self.cluster_id)

      File "/home/jenkins/workspace/gate-sahara_tests-storm_1.0.1-u14-aio/sahara_tests/scenario/base.py", line 625, in _poll_cluster_status
        raise exc.TempestException(message)

    TempestException: An unknown exception occurred
    Details: Cluster in Error state with a message below:
    Scaling cluster failed for the following reason(s): An error occurred in thread 'storm-reconfigure-c2-346453-a05fab50-43aca382-zookeeper-9cf1e62c-0': RemoteCommandException: Error during command execution: "mv temp-file-cfcf6f17-1781-44b3-aced-79a073fa6833 /opt/zookeeper/zookeeper-3.4.6/conf/zoo.cfg"
    Return code: 1
    STDERR:
    mv: cannot move temp-file-cfcf6f17-1781-44b3-aced-79a073fa6833 to /opt/zookeeper/zookeeper-3.4.6/conf/zoo.cfg: No such file or directory

    Error ID: 6ba30ed9-0629-4bf7-b759-7bafaac06b0a
    Error ID: 901ef4e2-9ed7-40b3-a355-e1779b7ad61b
    Traceback (most recent call last):
      File "/usr/local/lib/python2.7/dist-packages/sahara/context.py", line 168, in _wrapper
        func(*args, **kwargs)
      File "/usr/local/lib/python2.7/dist-packages/sahara/utils/cluster_progress_ops.py", line 139, in handler
        add_fail_event(instance, e)
      File "/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 220, in __exit__
        self.force_reraise()
      File "/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 196, in force_reraise
        six.reraise(self.type_, self.value, self.tb)
      File "/usr/local/lib/python2.7/dist-packages/sahara/utils/cluster_progress_ops.py", line 136, in handler
        value = func(*args, **kwargs)
      File "/usr/local/lib/python2.7/dist-packages/sahara/plugins/storm/plugin.py", line 303, in _push_configs_to_existing_node
        self._push_zk_configs(r, files_zookeeper)
      File "/usr/local/lib/python2.7/dist-packages/sahara/plugins/storm/plugin.py", line 319, in _push_zk_configs
        r.write_files_to(files, run_as_root=True)
      File "/usr/local/lib/python2.7/dist-packages/sahara/utils/ssh_remote.py", line 819, in write_files_to
        self._run_s(_write_files_to, timeout, description, files, run_as_root)
      File "/usr/local/lib/python2.7/dist-packages/sahara/utils/ssh_remote.py", line 738, in _run_s
        description, *args, **kwargs)
      File "/usr/local/lib/python2.7/dist-packages/sahara/utils/ssh_remote.py", line 728, in _run_with_log
        return self._run(func, *args, **kwargs)
      File "/usr/local/lib/python2.7/dist-packages/sahara/utils/ssh_remote.py", line 717, in _run
        procutils.shutdown_subprocess(proc, _cleanup)
      File "/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 220, in __exit__
        self.force_reraise()
      File "/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 196, in force_reraise
        six.reraise(self.type_, self.value, self.tb)
      File "/usr/local/lib/python2.7/dist-packages/sahara/utils/ssh_remote.py", line 714, in _run
        return procutils.run_in_subprocess(proc, func, args, kwargs)
      File "/usr/local/lib/python2.7/dist-packages/sahara/utils/procutils.py", line 57, in run_in_subprocess
        raise exceptions.SubprocessException(result['exception'])
    SubprocessException: RemoteCommandException: Error during command execution: "mv temp-file-cfcf6f17-1781-44b3-aced-79a073fa6833 /opt/zookeeper/zookeeper-3.4.6/conf/zoo.cfg"
    Return code: 1
    STDERR:
    mv: cannot move temp-file-cfcf6f17-1781-44b3-aced-79a073fa6833 to /opt/zookeeper/zookeeper-3.4.6/conf/zoo.cfg: No such file or directory

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/348380

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/348380
Committed: https://git.openstack.org/cgit/openstack/sahara/commit/?id=4bb6437f9a0a4113c7b3cc3e6c4c364f57d17230
Submitter: Jenkins
Branch: master

commit 4bb6437f9a0a4113c7b3cc3e6c4c364f57d17230
Author: Telles Nobrega <email address hidden>
Date: Thu Jul 28 11:15:12 2016 -0300

    Changing zookeeper path while updating conf

    Zookeeper path is hardcoded but we recently changed the path to avoid
    having to update the path every time zookeeper changed versions. We
    forgot to update this path in one place which causes the cluster to fail
    to scale. The patch fix that

    Change-Id: Idde36e39ac4c2e2e006b4a92d92e77440666c314
    Closes-bug: #1607386

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/sahara 5.0.0.0b3 development milestone.