puppet-ceph

Caps changes for pre-existing keys are not applied

Bug #1606918 reported by Giulio Fidente
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
puppet-ceph
Fix Released
High
Giulio Fidente

Bug Description

Changing the caps for a pre-existing key does not produce any update because the unless clause is only checking for the existence of the key [1]

1. https://github.com/openstack/puppet-ceph/blob/master/manifests/key.pp#L122

Emilien Macchi (emilienm)
Changed in puppet-ceph:
importance: Undecided → High
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-ceph (master)

Fix proposed to branch: master
Review: https://review.openstack.org/347860

OpenStack Infra (hudson-openstack)
Changed in puppet-ceph:
assignee: nobody → Giulio Fidente (gfidente)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-ceph (master)

Reviewed: https://review.openstack.org/347860
Committed: https://git.openstack.org/cgit/openstack/puppet-ceph/commit/?id=d823bf6ac91eb1fd12b0acea5161ba83b819f9f7
Submitter: Jenkins
Branch: master

commit d823bf6ac91eb1fd12b0acea5161ba83b819f9f7
Author: Giulio Fidente <email address hidden>
Date: Wed Jul 27 16:09:49 2016 +0200

    Refresh keys if caps are changed

    Updates the local keyring if any of its param (including caps) are
    changed.

    Change-Id: I24abbf23cae4f3449c3f1d46df3b3b0a7422c839
    Closes-Bug: 1606918
    Co-Authored-By: Jiri Stransky <email address hidden>

Changed in puppet-ceph:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-ceph (stable/hammer)

Fix proposed to branch: stable/hammer
Review: https://review.openstack.org/350512

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-ceph (stable/hammer)

Reviewed: https://review.openstack.org/350512
Committed: https://git.openstack.org/cgit/openstack/puppet-ceph/commit/?id=9ae1658a1bbc9887983a5bfb37fad2f3f6c9726b
Submitter: Jenkins
Branch: stable/hammer

commit 9ae1658a1bbc9887983a5bfb37fad2f3f6c9726b
Author: Giulio Fidente <email address hidden>
Date: Wed Jul 27 16:09:49 2016 +0200

    Refresh keys if caps are changed

    Updates the local keyring if any of its param (including caps) are
    changed.

    Change-Id: I24abbf23cae4f3449c3f1d46df3b3b0a7422c839
    Closes-Bug: 1606918
    Co-Authored-By: Jiri Stransky <email address hidden>
    (cherry picked from commit d823bf6ac91eb1fd12b0acea5161ba83b819f9f7)

tags: added: in-stable-hammer
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.