Set node status ERROR when physical id is none

[EldonZhao]

When creating node, sometimes it doesn't return physical id of the node. Now, we just return false, but the node status is still CREATING.
I think we may set node status ERROR.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/347732

[Qiming Teng (tengqim)]

we do have a wait_for_server method at the driver layer. If the node status is not ACTIVE during the given timeout, we may need to raise a ProfileOperationTimeout exception. By catching this exception at a higher layer, we can output a better error message if that is the case.

[Yanyan Hu (yanyanhu)]

Currently, timeout exception has been handled and converted to internalerror eception in the following code:
http://git.openstack.org/cgit/openstack/senlin/tree/senlin/drivers/openstack/sdk.py#n70

So physical_id==None means exception happened during Profile.create_object and it was not caught correctly. Maybe need to dig more here to find the reason if it happens.

[OpenStack Infra (hudson-openstack)]

Change abandoned by EldonZhao ([e-mail]) on branch: master
Review: https://review.openstack.org/347732

[Qiming Teng (tengqim)]

This has been fixed in another patch. Please reopen it if the issue is still there.