[DM]: DM crashes if vendor name is configured for any PR

Bug #1606729 reported by Suresh Balineni
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R3.0
Fix Committed
High
Suresh Balineni
R3.1
Fix Committed
High
Suresh Balineni
Trunk
Fix Committed
High
Suresh Balineni

Bug Description

DM crashes if PR's vendor name is not configured.

DM auto assigns vendor name to '' only if vendor name is not present in the config object, but UI is setting value to None, and hence DM could not assign vendor name to ''. For this reason, DM crashes. Need to handle gracefully.

Traceback (most recent call last):
  File "/usr/bin/contrail-device-manager", line 9, in <module>
    load_entry_point('device-manager==0.1dev', 'console_scripts', 'contrail-device-manager')()
  File "/usr/lib/python2.7/dist-packages/device_manager/device_manager.py", line 600, in server_main
    main()
  File "/usr/lib/python2.7/dist-packages/device_manager/device_manager.py", line 589, in main
    args)
  File "/usr/lib/python2.7/dist-packages/cfgm_common/zkclient.py", line 344, in master_election
    self._election.run(func, *args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/kazoo/recipe/election.py", line 48, in run
    func(*args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/device_manager/device_manager.py", line 594, in run_device_manager
    device_manager = DeviceManager(args)
  File "/usr/lib/python2.7/dist-packages/device_manager/device_manager.py", line 251, in __init__
    pr = PhysicalRouterDM.locate(obj['uuid'], obj)
  File "/usr/lib/python2.7/dist-packages/cfgm_common/vnc_db.py", line 64, in locate
    obj = cls(key, *args)
  File "/usr/lib/python2.7/dist-packages/device_manager/db.py", line 125, in __init__
    self.uve_send()
  File "/usr/lib/python2.7/dist-packages/device_manager/db.py", line 730, in uve_send
    product_info=self.vendor + ':' + self.product)
TypeError: unsupported operand type(s) for +: 'NoneType' and 'str'

Changed in juniperopenstack:
assignee: nobody → Suresh Balineni (sbalineni)
importance: Undecided → High
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/22458
Submitter: Suresh Balineni (<email address hidden>)

Nischal Sheth (nsheth)
tags: added: device-manager
information type: Proprietary → Public
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.1

Review in progress for https://review.opencontrail.org/22597
Submitter: Suresh Balineni (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.0

Review in progress for https://review.opencontrail.org/22598
Submitter: Suresh Balineni (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/22458
Committed: http://github.org/Juniper/contrail-controller/commit/51b93c9e0533ec3d89f1e7bada59775833c8d2ec
Submitter: Zuul
Branch: master

commit 51b93c9e0533ec3d89f1e7bada59775833c8d2ec
Author: sbalineni <email address hidden>
Date: Tue Jul 26 16:34:23 2016 -0700

DM: if vendor name is not configured using UI, DM crashes. Fixed.

Change-Id: I86815593c051acf33df2ac93c3b05790b93478dd
Closes-Bug: #1606729

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/22598
Committed: http://github.org/Juniper/contrail-controller/commit/4d3f81f74faaf9bb30526e79df3e74a64edce821
Submitter: Zuul
Branch: R3.0

commit 4d3f81f74faaf9bb30526e79df3e74a64edce821
Author: sbalineni <email address hidden>
Date: Tue Jul 26 16:34:23 2016 -0700

DM: if vendor name is not configured using UI, DM crashes. Fixed.

Change-Id: I86815593c051acf33df2ac93c3b05790b93478dd
Closes-Bug: #1606729

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/22597
Committed: http://github.org/Juniper/contrail-controller/commit/12551ea6af814e3c41ed7bfe0c9c7b60b08928c9
Submitter: Zuul
Branch: R3.1

commit 12551ea6af814e3c41ed7bfe0c9c7b60b08928c9
Author: sbalineni <email address hidden>
Date: Tue Jul 26 16:34:23 2016 -0700

DM: if vendor name is not configured using UI, DM crashes. Fixed.

Change-Id: I86815593c051acf33df2ac93c3b05790b93478dd
Closes-Bug: #1606729

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.