Juniper Openstack

[UI] https call failing to openstack services

Bug #1606646 reported by Biswajit Mandal
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R2.21.x
In Progress
Undecided
Biswajit Mandal
R3.0
Fix Committed
Undecided
Biswajit Mandal
Juniper Openstack r3.0.3.0
R3.0.2.x
Fix Committed
Undecided
Biswajit Mandal
Juniper Openstack r3.0.2.1
R3.1
Fix Committed
Undecided
Biswajit Mandal
Juniper Openstack r3.1.1.0
Trunk
Fix Committed
Undecided
Biswajit Mandal
Juniper Openstack r3.2.0.0-fcs "r3.2.0.0"

Bug Description

Post 0.9.1 node version, https request to openstack services fails.

Tags: blocker ui
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.1

Review in progress for https://review.opencontrail.org/22440
Submitter: Biswajit Mandal (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/22441
Submitter: Biswajit Mandal (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.1

Review in progress for https://review.opencontrail.org/22440
Submitter: Biswajit Mandal (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/22440
Committed: http://github.org/Juniper/contrail-web-core/commit/60c214946aa0ceb34e668a212a41036b693e63df
Submitter: Zuul
Branch: R3.1

commit 60c214946aa0ceb34e668a212a41036b693e63df
Author: Biswajit Mandal <email address hidden>
Date: Tue Jul 26 23:10:05 2016 +0530

Closes-Bug: #1606646
Post node version 0.9.1, tls, https: validate server certificate by default.
So in case self signed certificate, UI will not work with https request to
openstack services.
https://github.com/mscdex/node-imap/issues/181#issuecomment-14781480
Fix: Added rejectUnauthorized flag.

In node post v0.11.14, we have custom checkServerIdentity in options to have
more control.

UT Results:
+++++++++++
contrail-web-controller:
------------------------
PhantomJS 1.9.8 (Mac OS X 10.9.5): Executed 376 of 376 SUCCESS (1 min 41.645 secs / 1 min 39.143 secs)
Done, without errors.

contrail-web-server-manager:
----------------------------
PhantomJS 1.9.8 (Mac OS X 10.9.5): Executed 89 of 89 SUCCESS (11.9 secs / 11.643 secs)
Done, without errors.

contrail-web-storage:
--------------------
PhantomJS 1.9.8 (Mac OS X 0.0.0): Executed 84 of 84 SUCCESS (20.301 secs / 18.748 secs)
Done, without errors.

Change-Id: Iec589a59b5ae153c3b6a57ad1e96a025c8a9280e

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/22863
Submitter: Biswajit Mandal (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged
Download full text (3.7 KiB)

Reviewed: https://review.opencontrail.org/22863
Committed: http://github.org/Juniper/contrail-web-core/commit/d7fbde051679542970597cf680e4026403eeb1cf
Submitter: Zuul
Branch: master

commit d7fbde051679542970597cf680e4026403eeb1cf
Author: Biswajit Mandal <email address hidden>
Date: Thu Jul 21 15:25:30 2016 +0530

Closes-Bug: #1605163
This is side effect of the below fix:
https://github.com/Juniper/contrail-web-core/commit/f10620ede1f9f28858a9b418ec26093c57f00c41
Comuting data before Content-Length header assignement.

Change-Id: I100ab66856595688e97a74a54ce534fcdc201a36
(cherry picked from commit 15ba7405f1a000dcf3537cef7c2191f91a1c0fb5)

Closes-Bug: #1606646
Post node version 0.9.1, tls, https: validate server certificate by default.
So in case self signed certificate, UI will not work with https request to
openstack services.
https://github.com/mscdex/node-imap/issues/181#issuecomment-14781480
Fix: Added rejectUnauthorized flag.

In node post v0.11.14, we have custom checkServerIdentity in options to have
more control.

UT Results:
+++++++++++
contrail-web-controller:
------------------------
PhantomJS 1.9.8 (Mac OS X 10.9.5): Executed 376 of 376 SUCCESS (1 min 41.645 secs / 1 min 39.143 secs)
Done, without errors.

contrail-web-server-manager:
----------------------------
PhantomJS 1.9.8 (Mac OS X 10.9.5): Executed 89 of 89 SUCCESS (11.9 secs / 11.643 secs)
Done, without errors.

contrail-web-storage:
--------------------
PhantomJS 1.9.8 (Mac OS X 0.0.0): Executed 84 of 84 SUCCESS (20.301 secs / 18.748 secs)
Done, without errors.

Change-Id: Iec589a59b5ae153c3b6a57ad1e96a025c8a9280e
(cherry picked from commit 60c214946aa0ceb34e668a212a41036b693e63df)

Related-Bug: #1606775
Once we get logout request, immediately invalidate session authentication, and
clear _csrf, connect.sid cookie, do not wait for deleting the token.

UT Results:
+++++++++++
contrail-web-controller:
------------------------
PhantomJS 1.9.8 (Mac OS X 10.9.5): Executed 376 of 376 SUCCESS (1 min 41.645 secs / 1 min 39.143 secs)
Done, without errors.

contrail-web-server-manager:
----------------------------
PhantomJS 1.9.8 (Mac OS X 10.9.5): Executed 89 of 89 SUCCESS (11.9 secs / 11.643 secs)
Done, without errors.

contrail-web-storage:
--------------------
PhantomJS 1.9.8 (Mac OS X 0.0.0): Executed 84 of 84 SUCCESS (20.301 secs / 18.748 secs)
Done, without errors.

Change-Id: Ie11186071bb92f116b9472473170e19c58010adf
(cherry picked from commit b1603b99d7d14d812613c6874204f0c5e0ef5712)

Closes-Bug: #1584651
doDeepSort, align the keys according to the type of input object

Change-Id: I2c791ae2e45ed081fde9947508bf9ec2bdd25675
(cherry picked from commit c2913b7a05099679ab3c73686f3575ab04d822e1)

Closes-Bug: #1608383
In Microsoft EDGE Browser, response code 307, does not lead the browser to
redirect to certain URL, so sending 200 responseCode. (if userAgent
contains MSIE/Trident/Edge)

Change-Id: I4f971f66de19db915492884cbaf9ef0b09f05eb7
(cherry picked from commit 562c002dd70c48b430f8441f0cc3c7a756541113)

Closes-Bug: #1609425
In earlier releases we had /login and /vcenter/login, from R3.1
we have changed login to "/" and "/vcenter" only, so in case
user does "/login" or "...

Read more...

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.0

Review in progress for https://review.opencontrail.org/23042
Submitter: Biswajit Mandal (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.0.2.x

Review in progress for https://review.opencontrail.org/23043
Submitter: Biswajit Mandal (<email address hidden>)

Rahul (rahuls)
information type: Proprietary → Public
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/23042
Committed: http://github.org/Juniper/contrail-web-core/commit/2465d3eebc3ae8b951305972ed6fd9210ce286d3
Submitter: Zuul
Branch: R3.0

commit 2465d3eebc3ae8b951305972ed6fd9210ce286d3
Author: Biswajit Mandal <email address hidden>
Date: Tue Jul 26 23:10:05 2016 +0530

Closes-Bug: #1606646
Post node version 0.9.1, tls, https: validate server certificate by default.
So in case self signed certificate, UI will not work with https request to
openstack services.
https://github.com/mscdex/node-imap/issues/181#issuecomment-14781480
Fix: Added rejectUnauthorized flag.

In node post v0.11.14, we have custom checkServerIdentity in options to have
more control.

UT Results:
+++++++++++
contrail-web-controller:
------------------------
PhantomJS 1.9.8 (Mac OS X 10.9.5): Executed 376 of 376 SUCCESS (1 min 41.645 secs / 1 min 39.143 secs)
Done, without errors.

contrail-web-server-manager:
----------------------------
PhantomJS 1.9.8 (Mac OS X 10.9.5): Executed 89 of 89 SUCCESS (11.9 secs / 11.643 secs)
Done, without errors.

contrail-web-storage:
--------------------
PhantomJS 1.9.8 (Mac OS X 0.0.0): Executed 84 of 84 SUCCESS (20.301 secs / 18.748 secs)
Done, without errors.

Change-Id: Iec589a59b5ae153c3b6a57ad1e96a025c8a9280e
(cherry picked from commit 60c214946aa0ceb34e668a212a41036b693e63df)

Avoid passing an empty 'data' object to restler.get calls.

Restler changes Content-Type to 'application/x-www-form-urlencoded' even
for GET requests, as long as data is not a string. That breaks some nova
API calls when Mitaka nova-api is used, as it now expects to get
"application/json" for all queries. Make sure we pass data object only
for POST and PUT calls.

Change-Id: Ieaf1622dec703404d9672681a9cd0d35199326d7
Closes-Bug: 1591393
(cherry picked from commit f10620ede1f9f28858a9b418ec26093c57f00c41)

Closes-Bug: #1605163
This is side effect of the below fix:
https://github.com/Juniper/contrail-web-core/commit/f10620ede1f9f28858a9b418ec26093c57f00c41
Comuting data before Content-Length header assignement.

Change-Id: I100ab66856595688e97a74a54ce534fcdc201a36
(cherry picked from commit 15ba7405f1a000dcf3537cef7c2191f91a1c0fb5)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.1

Review in progress for https://review.opencontrail.org/23255
Submitter: Biswajit Mandal (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.0

Review in progress for https://review.opencontrail.org/23381
Submitter: Biswajit Mandal (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/23382
Submitter: Biswajit Mandal (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/23382
Committed: http://github.org/Juniper/contrail-web-core/commit/08b4c1e87ca086b2865c713688ace630baa5d5dc
Submitter: Zuul
Branch: master

commit 08b4c1e87ca086b2865c713688ace630baa5d5dc
Author: Biswajit Mandal <email address hidden>
Date: Fri Aug 12 22:24:05 2016 +0530

Closes-Bug: #1606646
Add cert/key in SSL request options.

Change-Id: Icec3f288ac58d4c08aced6f1cda6d0d92eca81ef
(cherry picked from commit 348d55ee64b54418c7120a85262b00e513e1334e)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/23381
Committed: http://github.org/Juniper/contrail-web-core/commit/8ac20e81deddf17b6b4b47e764974b5b2cf522ba
Submitter: Zuul
Branch: R3.0

commit 8ac20e81deddf17b6b4b47e764974b5b2cf522ba
Author: Biswajit Mandal <email address hidden>
Date: Fri Aug 12 22:24:05 2016 +0530

Closes-Bug: #1606646
Add cert/key in SSL request options.

Change-Id: Icec3f288ac58d4c08aced6f1cda6d0d92eca81ef
(cherry picked from commit 348d55ee64b54418c7120a85262b00e513e1334e)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/23255
Committed: http://github.org/Juniper/contrail-web-core/commit/348d55ee64b54418c7120a85262b00e513e1334e
Submitter: Zuul
Branch: R3.1

commit 348d55ee64b54418c7120a85262b00e513e1334e
Author: Biswajit Mandal <email address hidden>
Date: Fri Aug 12 22:24:05 2016 +0530

Closes-Bug: #1606646
Add cert/key in SSL request options.

Change-Id: Icec3f288ac58d4c08aced6f1cda6d0d92eca81ef

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/23043
Committed: http://github.org/Juniper/contrail-web-core/commit/44f8bdd31e4f285203cddca3772b45f495b49a8a
Submitter: Zuul
Branch: R3.0.2.x

commit 44f8bdd31e4f285203cddca3772b45f495b49a8a
Author: Biswajit Mandal <email address hidden>
Date: Tue Jul 26 23:10:05 2016 +0530

Closes-Bug: #1606646
Post node version 0.9.1, tls, https: validate server certificate by default.
So in case self signed certificate, UI will not work with https request to
openstack services.
https://github.com/mscdex/node-imap/issues/181#issuecomment-14781480
Fix: Added rejectUnauthorized flag.

In node post v0.11.14, we have custom checkServerIdentity in options to have
more control.

UT Results:
+++++++++++
contrail-web-controller:
------------------------
PhantomJS 1.9.8 (Mac OS X 10.9.5): Executed 376 of 376 SUCCESS (1 min 41.645 secs / 1 min 39.143 secs)
Done, without errors.

contrail-web-server-manager:
----------------------------
PhantomJS 1.9.8 (Mac OS X 10.9.5): Executed 89 of 89 SUCCESS (11.9 secs / 11.643 secs)
Done, without errors.

contrail-web-storage:
--------------------
PhantomJS 1.9.8 (Mac OS X 0.0.0): Executed 84 of 84 SUCCESS (20.301 secs / 18.748 secs)
Done, without errors.

Change-Id: Iec589a59b5ae153c3b6a57ad1e96a025c8a9280e
(cherry picked from commit 60c214946aa0ceb34e668a212a41036b693e63df)

Avoid passing an empty 'data' object to restler.get calls.

Restler changes Content-Type to 'application/x-www-form-urlencoded' even
for GET requests, as long as data is not a string. That breaks some nova
API calls when Mitaka nova-api is used, as it now expects to get
"application/json" for all queries. Make sure we pass data object only
for POST and PUT calls.

Change-Id: Ieaf1622dec703404d9672681a9cd0d35199326d7
Closes-Bug: 1591393
(cherry picked from commit f10620ede1f9f28858a9b418ec26093c57f00c41)

Closes-Bug: #1605163
This is side effect of the below fix:
https://github.com/Juniper/contrail-web-core/commit/f10620ede1f9f28858a9b418ec26093c57f00c41
Comuting data before Content-Length header assignement.

Change-Id: I100ab66856595688e97a74a54ce534fcdc201a36
(cherry picked from commit 15ba7405f1a000dcf3537cef7c2191f91a1c0fb5)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.21.x

Review in progress for https://review.opencontrail.org/27999
Submitter: Biswajit Mandal (<email address hidden>)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.