Watcher base action abstract methods should be renamed for consistency
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
watcher |
Fix Released
|
Low
|
Joe Cropper |
Bug Description
This is a nit, but we should be consistent. The watcher.
@abc.
def precondition(self):
"""Hook: called before the execution of an action
This method can be used to perform some initializations or to make
some more advanced validation on its input parameters. So if you wish
to block its execution based on this factor, `raise` the related
exception.
"""
raise NotImplementedE
@abc.
def postcondition(
"""Hook: called after the execution of an action
This function is called regardless of whether an action succeded or
not. So you can use it to perform cleanup operations.
"""
raise NotImplementedE
And in other areas of similar patterns, we use pre_condition and post_condition. We should clean this up and use consistent formatting of the method names (read: rename these to use the '_' delimiter).
Changed in watcher: | |
importance: | Undecided → Low |
Changed in watcher: | |
assignee: | nobody → Joe Cropper (jwcroppe) |
Changed in watcher: | |
milestone: | none → newton-3 |
Fix proposed to branch: master /review. openstack. org/352046
Review: https:/