Public and Control VIP interface should be automatically set in tripleO

[Tim Rozet]

When deploying, PublicVIPInterface heat parameter is used in order to bind the public VIP to an interface in puppet-tripleo loadbalancer.pp (stable/mitaka), keepalived.pp (master). This value defaults to 'br-ex' (which is fine). However, when using a VLAN deployment this needs to be changed to be the VLAN interface used for the public network. The current description of the heat parameter is:

  PublicVirtualInterface:
    default: 'br-ex'
    description: >
        Specifies the interface where the public-facing virtual ip will be assigned.
        This should be int_public when a VLAN is being used.
    type: string

This description should be at least changed to say something like: "When using a VLAN deployment this should be set to the vlan<num> interface used for the public network, i.e. vlan200 for a public network on using VLAN 200."

More importantly, this logic should be changed to automatically set the heat parameter. Since a user has already provided the nic template which defines the VLAN interface where the public network resides, there is no point in making a user input it again.

[Tim Rozet (trozet)]

Note this also includes ControlVirtualInterface that at the moment defaults to br-ex. This should really be on the admin network interface and the deployment tool should be able to figure this out.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/390400

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/390401

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/390400
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=87763459ae57614e092f772595a03e7d552f96d1
Submitter: Jenkins
Branch: master

commit 87763459ae57614e092f772595a03e7d552f96d1
Author: Tim Rozet <email address hidden>
Date: Mon Oct 24 16:30:22 2016 -0400

    Adds auto-detection for VIP interfaces

    Previously the ctrl plane VIP would default to 'br-ex' which in non-vlan
    deployments ends up being the wrong interface. The public VIP interface
    was also defaulted to 'br-ex' which would be incorrect for vlan based
    deployments. Since a user has already given the nic template (and in
    most cases the subnet that corresponds to the nic) the installer should
    be able to figure out which interface the public/control vip should be
    on.

    These changes enable that type of auto-detection, unless a user
    explicitly overrides the heat parameters for ControlVirtualInterface and
    PublicVirtualInterface. Also removes calling keepalived from haproxy
    now that the services are composed separately on the Controller role.

    Partial-Bug: 1606632

    Change-Id: I05105fce85be8ace986db351cdca2916f405ed04
    Signed-off-by: Tim Rozet <email address hidden>

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/390401
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=f49d4d23f6a294b535451180a1c006f50ee582c2
Submitter: Jenkins
Branch: master

commit f49d4d23f6a294b535451180a1c006f50ee582c2
Author: Tim Rozet <email address hidden>
Date: Mon Oct 24 16:36:10 2016 -0400

    Enables auto-detection for VIP interfaces

    Previously the ctrl plane VIP would default to 'br-ex' which in non-vlan
    deployments ends up being the wrong interface. The public VIP interface
    was also defaulted to 'br-ex' which would be incorrect for vlan based
    deployments. Since a user has already given the nic template (and in
    most cases the subnet that corresponds to the nic) the installer should
    be able to figure out which interface the public/control vip should be
    on.

    These changes enable that type of auto-detection, unless a user
    explicitly overrides the heat parameters for ControlVirtualInterface and
    PublicVirtualInterface. Also, incorrect parameters from haproxy service
    are removed.

    Depends-On: I05105fce85be8ace986db351cdca2916f405ed04

    Closes-Bug: 1606632

    Change-Id: I3c1c39824ec32ced304a782edc6ef49c0769c108
    Signed-off-by: Tim Rozet <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/407194

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/407196

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/407194
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=16a020266420ad78cb4538f08f3fb05d35596622
Submitter: Jenkins
Branch: stable/newton

commit 16a020266420ad78cb4538f08f3fb05d35596622
Author: Tim Rozet <email address hidden>
Date: Mon Oct 24 16:30:22 2016 -0400

    Adds auto-detection for VIP interfaces

    Previously the ctrl plane VIP would default to 'br-ex' which in non-vlan
    deployments ends up being the wrong interface. The public VIP interface
    was also defaulted to 'br-ex' which would be incorrect for vlan based
    deployments. Since a user has already given the nic template (and in
    most cases the subnet that corresponds to the nic) the installer should
    be able to figure out which interface the public/control vip should be
    on.

    These changes enable that type of auto-detection, unless a user
    explicitly overrides the heat parameters for ControlVirtualInterface and
    PublicVirtualInterface. Also removes calling keepalived from haproxy
    now that the services are composed separately on the Controller role.

    Partial-Bug: 1606632

    Change-Id: I05105fce85be8ace986db351cdca2916f405ed04
    Signed-off-by: Tim Rozet <email address hidden>
    (cherry picked from commit 87763459ae57614e092f772595a03e7d552f96d1)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 6.0.0.0b2 development milestone.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/407196
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=b45387c273d49af3e953ef5f7a1006276afc0fe9
Submitter: Jenkins
Branch: stable/newton

commit b45387c273d49af3e953ef5f7a1006276afc0fe9
Author: Tim Rozet <email address hidden>
Date: Mon Oct 24 16:36:10 2016 -0400

    Enables auto-detection for VIP interfaces

    Previously the ctrl plane VIP would default to 'br-ex' which in non-vlan
    deployments ends up being the wrong interface. The public VIP interface
    was also defaulted to 'br-ex' which would be incorrect for vlan based
    deployments. Since a user has already given the nic template (and in
    most cases the subnet that corresponds to the nic) the installer should
    be able to figure out which interface the public/control vip should be
    on.

    These changes enable that type of auto-detection, unless a user
    explicitly overrides the heat parameters for ControlVirtualInterface and
    PublicVirtualInterface. Also, incorrect parameters from haproxy service
    are removed.

    Depends-On: I05105fce85be8ace986db351cdca2916f405ed04

    Closes-Bug: 1606632

    Change-Id: I3c1c39824ec32ced304a782edc6ef49c0769c108
    Signed-off-by: Tim Rozet <email address hidden>
    (cherry picked from commit f49d4d23f6a294b535451180a1c006f50ee582c2)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 5.3.0 release.