Floating network created as shared

[Andrey Grebennikov]

MOS8 (Same with MOS9)

Public network is created with "shared" attribute, which in common scenario doesn't make sense. Users should not be allowed to directly allocate IPs from this network and assign them to the instances.

 $floating_net_shared = try_get_value($nets, "${floating_net}/shared", false)

This defines the type of the network, and Hiera has "shared"=>true for the "floating_net"

Need to unset "shared"=>true for the external network.

[Oleksiy Molchanov (omolchanov)]

It seems that external network has shared == False for Fuel 9 and 8.

https://github.com/openstack/fuel-web/blob/master/nailgun/nailgun/extensions/network_manager/serializers/neutron_serializers.py#L314-L348

https://github.com/openstack/fuel-web/blob/af68ca5c5bd566d6cb83eebf620815b7abe5b598/nailgun/nailgun/extensions/network_manager/serializers/neutron_serializers.py#L314-L349

[Andrey Grebennikov (agrebennikov)]

Turned out the reason for the network to have "Shared" attribute is Contrail plugin.
It redefines all networks in hiera, and it specifically sets up "Shared=True" for the external network.

Please mark as invalid.