should change the dict to lowercase

Bug #1606351 reported by Polly Zhou
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
microversion-parse
Fix Released
Undecided
Unassigned

Bug Description

In the fold_headers function, if the headers behaves like a dict, return it. So the headers don't get to change to lowercase that can not be parsed correctly.

Changing to lowercase if the headers behave like dict is needed.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to microversion-parse (master)

Fix proposed to branch: master
Review: https://review.openstack.org/347548

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/347993

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on microversion-parse (master)

Change abandoned by Polly Zhou (<email address hidden>) on branch: master
Review: https://review.openstack.org/347548
Reason: Abandon because submitted 2 changes for review, the new one is Change 347993

Dmitry Tantsur (divius)
no longer affects: ironic
Revision history for this message
Polly Zhou (polly-zhou) wrote :

May i know why it no longer affects ironic

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to microversion-parse (master)

Reviewed: https://review.openstack.org/347993
Committed: https://git.openstack.org/cgit/openstack/microversion-parse/commit/?id=1f6eac7c3df048679663919f75c2bcecd3e183a2
Submitter: Jenkins
Branch: master

commit 1f6eac7c3df048679663919f75c2bcecd3e183a2
Author: PollyZ <email address hidden>
Date: Tue Jul 26 15:28:18 2016 -0500

    Convert dict headers and Webob headers into lowercase.

    In the fold_headers function, if the headers behaves like a dict,
    they were being retured unchanged. This would cause issues in the
    later processing to extract the microversion header, which matches
    on lower case strings.

    Convert these headers to lowercase also provide a test case to
    validate the header is being parsed correctly.

    Change-Id: I8501c813d668c0a32905906e4ef3f8c6c6b12de2
    Close-Bug:# 1606351

Revision history for this message
Chris Dent (cdent) wrote :

This was released as part of 0.1.4 2016/08/05

Changed in microversion-parse:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.