[Upgrade 7.0 to 9.0] VIPs are empty on primary controller upgrade

[Arthur Svechnikov]

[root@fuel ~]# octane upgrade-node --isolated 5 1
2016-07-25 08:11:07 INFO requests.packages.urllib3.connectionpool Starting new HTTP connection (1): 10.109.10.2
2016-07-25 08:11:07 INFO requests.packages.urllib3.connectionpool Starting new HTTP connection (1): 10.109.10.2
2016-07-25 08:11:07 INFO requests.packages.urllib3.connectionpool Starting new HTTP connection (1): 10.109.10.2
2016-07-25 08:11:07 INFO requests.packages.urllib3.connectionpool Starting new HTTP connection (1): 10.109.10.2
2016-07-25 08:11:07 INFO octane.util.subprocess Started process fuel2[9944]: fuel2 --debug env copy vips 5
2016-07-25 08:11:09 INFO octane.util.subprocess fuel2[9944] stdout: VIPs successfully copied from the original cluster to seed cluster 5
2016-07-25 08:11:09 INFO octane.util.subprocess Process fuel2 finished with return value 0
2016-07-25 08:11:14 INFO octane.util.env Nodes deploy started. Please wait...
2016-07-25 08:11:14 ERROR octane Node 1 fell into error status
[root@fuel ~]# fuel vip --env 5 -d
VIP configuration for environment with id=5 downloaded to /root/vips_5.yaml
[root@fuel ~]# cat vips_5.yaml
[]
[root@fuel ~]#

The problem is in [0] method that removes all VIPs and doesn't create new

[0] https://github.com/openstack/fuel-web/blob/stable/mitaka/nailgun/nailgun/extensions/cluster_upgrade/upgrade.py#L181

Workaround:
 swap lines 181 and 180

[Ilya Kharin (akscram)]

It seems that this bug is not valid because this problem is not reproduced on the latest version.