Please merge hardware-monitor-1.4-1 (universe) from Debian unstable

Bug #160601 reported by drsatyriasis
6
Affects Status Importance Assigned to Milestone
hardware-monitor (Ubuntu)
Fix Released
Wishlist
Miguel Ruiz

Bug Description

Binary package hint: hardware-monitor

New debian package needs merging

Revision history for this message
drsatyriasis (drsatyriasis) wrote :

Just checking on this. If I did anything wrong in attempting to merge this package, I'd be more than obliged to attempt to correct my errors before they accure on the next merge/sync I attempt. Thanks, -drsatyriasis

Revision history for this message
Luca Falavigna (dktrkranz) wrote :

You should subscribe ubuntu-universe-sponsors to the bug in order to have your debdiff reviewed. I do it now, do not forget to do it yourself in the future to receive attention. Thanks for your work :)

Changed in hardware-monitor:
importance: Undecided → Wishlist
Revision history for this message
Cesare Tirabassi (norsetto) wrote :

Few comments:

1) Debian added the version (>= 2.6.0) to libgtkmm-2.4-dev. You removed it, why?
2) In your changelog you use gutsy, but the development version is hardy.
3) You have forgotten to list what changes you have carried over from previous ubuntu versions in changelog. Please add them.
4) You have many extraneous things in your debdiffs (mainly translation files). Please clean them before submitting again.
5) You have not covered the change implemented in 1.4-0ubuntu2 (patch from Christof Krüger to not count iowait as cpu load).

Otherwise good work!
Please re-subscribe u-u-s once you have corrected your patches.

Changed in hardware-monitor:
assignee: nobody → drsatyriasis
status: New → In Progress
Revision history for this message
Miguel Ruiz (mruiz) wrote :

I didn't know that someone was working on this merge. I said that I was working on it (DaD),

As Debian Import Freeze is near, I'm assigning this bug to me (I finished with the merge and the responsible is MIA since one month ago).

Greetings!

Changed in hardware-monitor:
assignee: drsatyriasis → mruiz
Revision history for this message
Daniel Holbach (dholbach) wrote :

The merge is generally ok, some bits that are superfluous:
 - debhelper (>> 4.2.13) -> debhelper (>= 5) (also debian/compat change)
 - Standards-Version bump, debian/dirs drop, drop of duplicate build-depends (these could get forwarded to debian instead)

Revision history for this message
Miguel Ruiz (mruiz) wrote :

Daniel:

I fixed the problems; I'll upload new debdiffs.

Cheers!

Revision history for this message
Miguel Ruiz (mruiz) wrote :
Revision history for this message
Miguel Ruiz (mruiz) wrote :
Revision history for this message
Luke Yelavich (themuso) wrote :

Ok, this bug should have losed automatically, but the syntax for the LP bug closure was slightly wrong. YOu missed out a :. Closing manually.

hardware-monitor (1.4-1ubuntu1) hardy; urgency=low

  * Merge from debian unstable (LP #160601), remaining changes:
    - Applied patch from Christof Krüger to not count iowait as cpu load.
    - Updated maintainer field.
    - Build-Depends: dropped libgnomemm-2.6-dev, libgnomeuimm-2.6-dev and duplicate
      libpanel-applet2-dev

 -- Miguel Ruiz <email address hidden> Wed, 12 Dec 2007 12:28:58 -0300

Changed in hardware-monitor:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.