On recording the mix to a file, there are the two options below:
#define SPLIT_650MB "650 MB (CD)"
#define SPLIT_700MB "700 MB (CD)"
#define SIZE_650MB Q_UINT64_C(650000000)
#define SIZE_700MB Q_UINT64_C(750000000)
This is erroneous for different reasons:
- First one: The 700MB one has 750 Million, which does not fit in a 700MB CD (if stored as data)
- Second one: it says it multiplies by 1000 instead of 1024 to leave space for headers (and cue file maybe), but then why not multiply by 1024 and round at the megabyte level? (680.000.000 and 733.000.000 respectively)
- Third: Those may be good values for encoded audio ( vorbis, mp3...), but when generating WAV files, one would expect that they represent the audio that can be recorded on a CD, not the size that a wav file uses.
Concretely,
650MB -> 74 Minutes -> 783.216.000 bytes
700MB -> 80 Minutes -> 846.720.000 bytes
Maybe it would be better to change the values as in the second point, and add two more options that cut at 74 and 80 minutes. The class RecordingManager is notified for both: size and duration.
https:/