not remove items from select list after batch deleting

Bug #1605083 reported by xujun
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
High
Richard Jones

Bug Description

Bug occurs in using batch delete more than one time in one page. Deleted items have not been removed from the select list after batch delete action.

hz-resource-table -> hz-dynamic-table -> hz-table

To fix this, hz-resource-table should call hz-table.clearSelected(). However, Angular is not well-design for multi nested directives. Exposing the func from inside hz-table to outside hz-resource-table may dirty the code.

I will find a solution in an action way.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/345813

Changed in horizon:
assignee: nobody → xujun (yamajik)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/352436

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (master)

Change abandoned by xujun (xu.jun@99cloud.net) on branch: master
Review: https://review.openstack.org/345813

Changed in horizon:
milestone: none → newton-rc1
Changed in horizon:
assignee: xujun (yamajik) → Richard Jones (r1chardj0n3s)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/352436
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=db032d6ad5e75d66d08f4b1a76b4b01ec2e0fc10
Submitter: Jenkins
Branch: master

commit db032d6ad5e75d66d08f4b1a76b4b01ec2e0fc10
Author: majik <xu.jun@99cloud.net>
Date: Mon Aug 8 21:55:24 2016 +0800

    fix table delete bug & collect table events

    Bug occurs in using batch delete more than one time in one page.
    Deleted items haven't been removed from selections
    after batch delete action.

    Change-Id: I13b4da7deb026c28e26910e0bd763960de4bffa8
    Closes-Bug: #1605083

Changed in horizon:
status: In Progress → Fix Released
Changed in horizon:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 10.0.0.0rc1

This issue was fixed in the openstack/horizon 10.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.