The error when trying to release a revision that's not a integer is ugly
Bug #1604815 reported by
Leo Arias
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Snapcraft |
Fix Released
|
High
|
Carlo Lobrano |
Bug Description
The error returned when I try to release to a revision that's not an integer I get an error that's not formatted for a user.
$ snapcraft release u1test20160920 notanumber edge
{'revision': ['This field must be an integer.']}
tags: | added: bitesize |
Changed in snapcraft: | |
assignee: | nobody → Carlo Lobrano (c-lobrano) |
status: | Triaged → In Progress |
Changed in snapcraft: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Yeah, that comes from the store:
"POST /dev/api/ snap-release/ HTTP/1.1" 400 None kyrofa/ src/snapcraft/ bin/snapcraft" , line 31, in <module> main.main( ) kyrofa/ src/snapcraft/ snapcraft/ main.py" , line 244, in main kyrofa/ src/snapcraft/ snapcraft/ main.py" , line 288, in run store_command( args) kyrofa/ src/snapcraft/ snapcraft/ main.py" , line 352, in _run_store_command '<snap- name>'] , args['<revision>'], [args[' <channel> ']]) kyrofa/ src/snapcraft/ snapcraft/ _store. py", line 559, in release snap_name, revision, release_channels) kyrofa/ src/snapcraft/ snapcraft/ storeapi/ __init_ _.py", line 213, in release sca.snap_ release, snap_name, revision, channels) kyrofa/ src/snapcraft/ snapcraft/ storeapi/ __init_ _.py", line 169, in _refresh_ if_necessary kyrofa/ src/snapcraft/ snapcraft/ storeapi/ __init_ _.py", line 565, in snap_release StoreReleaseErr or(data[ 'name'] , response) storeapi. errors. StoreReleaseErr or: {'revision': ['This field must be an integer.']}
Traceback (most recent call last):
File "/home/
snapcraft.
File "/home/
return run(args, project_options)
File "/home/
_run_
File "/home/
args[
File "/home/
channels = store.release(
File "/home/
self.
File "/home/
return func(*args, **kwargs)
File "/home/
raise errors.
snapcraft.
We need to parse that much better.