search data once when magic-search has inited

Bug #1604714 reported by xujun
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
xujun

Bug Description

When the page which containers hz-resource-table(magic-search) is on load, it sends get the same data twice. One is right, but another is called by the search event. The second one should not happen.

I find it out that the initial data of currentServerSearchParams in stMagicSearch is incorrect.
Initial currentServerSearchParams is {}, however, which should be {magicSearchQuery: ""}.

Changed in horizon:
assignee: nobody → xujun (yamajik)
status: New → In Progress
Revision history for this message
Matt Borland (palecrow) wrote :

Verified this behavior. When I go to the Images panel, I see:

[20/Jul/2016 13:27:04] "GET /api/glance/images/ HTTP/1.1" 200 4185
[20/Jul/2016 13:27:04] "GET /api/glance/images/ HTTP/1.1" 200 4185

Changed in horizon:
importance: Undecided → Medium
Matt Borland (palecrow)
Changed in horizon:
milestone: none → newton-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/344692
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=fb4b08ffc7277bfef7b513f6576bbb689c14e8c4
Submitter: Jenkins
Branch: master

commit fb4b08ffc7277bfef7b513f6576bbb689c14e8c4
Author: majik <xu.jun@99cloud.net>
Date: Wed Jul 20 17:55:16 2016 +0800

    fix magic search bug

    Two same requests are sent when magic-search is on load.
    One is right, but another is called by the search event.
    The second one should not happen.

    The initial data of currentServerSearchParams in stMagicSearch is wrong,
    which should be {magicSearchQuery: ""} instead of {}.

    Change-Id: Ia1e28e848daabe5685cb7a01c80ca1296131e616
    Closes-Bug: #1604714

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/horizon 10.0.0.0b3

This issue was fixed in the openstack/horizon 10.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.