"log to syslog" sometimes renders to "none" instead of "false"

Bug #1604575 reported by Ryan Beisner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Cinder-Ceph charm
Fix Released
Low
James Page
cinder-ceph (Juju Charms Collection)
Invalid
Low
James Page

Bug Description

use_syslog sometimes renders to "none" instead of "false" as expected.

For Precise-Icehouse, amulet tests show:

DEBUG:runner:DEBUG:amulet-logger:Validating config file data (global in /etc/ceph/ceph.conf on cinder/0)...
DEBUG:runner:cinder ceph config error: section [global] log to syslog:none != expected log to syslog:false

Ryan Beisner (1chb1n)
description: updated
Ryan Beisner (1chb1n)
summary: - use_syslog sometimes renders to "none" instead of "false"
+ "log to syslog" sometimes renders to "none" instead of "false"
Revision history for this message
James Page (james-page) wrote :

Confirmed:

log to syslog = none
err to syslog = none
clog to syslog = none

problem here is that the template expects a syslog flag to be populated, but this charm does not actually have a use-syslog configuration - we should add that.

Changed in cinder-ceph (Juju Charms Collection):
status: New → Triaged
importance: Undecided → Low
tags: added: bitsized
tags: added: bitesized
removed: bitsized
Changed in cinder-ceph (Juju Charms Collection):
assignee: nobody → James Page (james-page)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-cinder-ceph (master)

Fix proposed to branch: master
Review: https://review.openstack.org/428048

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-cinder-ceph (master)

Reviewed: https://review.openstack.org/428048
Committed: https://git.openstack.org/cgit/openstack/charm-cinder-ceph/commit/?id=799258193264fbe82327a031ea00ae936300e138
Submitter: Jenkins
Branch: master

commit 799258193264fbe82327a031ea00ae936300e138
Author: James Page <email address hidden>
Date: Thu Feb 2 09:33:11 2017 +0000

    Add use-syslog configuration option

    This config option is used in the ceph.conf template; add to
    charm configuration options to allow syslog to be enabled or
    disabled for ceph library usage.

    The existing context configuration for the charm will just
    pickup and use this configuration option, avoiding the current
    behaviour of writing out 'none' to the ceph.conf file.

    Change-Id: I40debfa5c8ee07999ed5e688e31d1c6ceffbea36
    Closes-Bug: 1604575

Changed in cinder-ceph (Juju Charms Collection):
status: In Progress → Fix Committed
James Page (james-page)
Changed in charm-cinder-ceph:
assignee: nobody → James Page (james-page)
importance: Undecided → Low
status: New → Fix Committed
Changed in cinder-ceph (Juju Charms Collection):
status: Fix Committed → Invalid
James Page (james-page)
Changed in charm-cinder-ceph:
milestone: none → 17.02
James Page (james-page)
Changed in charm-cinder-ceph:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.