polygon "twin hole" bug

[Bert Timmerman]

Hi all,

Evan found a bug in pcb-rnd which turned out to be a bug in pcb mainline as well. It is really easy to reproduce from scratch:

1. draw a poly
2. draw a hole in it (strange: first click ignored?)
3. keep on drawing the second hole (strange: marker is not moved?)
4. bug: the poly of step 1 is duplicated (copied in place), and the new hole is created on the new poly

Important: do not switch tool between step 2 and 3! This, together with the fact that it can be reproduced with both HIDs suggests it's a bug in core (the strangenesses are maybe related to handling of the mode variable, I have no idea how the poly gets dupped).

Detecting the duplication polys:

- save before and after step 4, compare the two save files; instead of one poly object with two holes there are two poly objects with one hole each

- move the poly after step 4; expected: moving one poly; what happens instead: moving the top poly, leaving the bottom poly in place

- in step 3 draw the second hole so that it has an intersection with the first; that intersection is the only copper hole at the end, because it is not covered by any of the polygons

In pcb-rnd I am still knee-deep in the conf rewrite, but I plan to look at this bug after I finish. In case someone debugs this in mainline, I'm interested in the result. Else I can share my findings/patches when I get to it, so mainline developers can fix this in mainline.

Regards,

Igor2

[Bert Timmerman (bert-timmerman)]

Fix pushed to home/bert/LP1604524_v2.

Please test and review.

[Bert Timmerman (bert-timmerman)]

Hi,

Cherry picked to master and pushed.

Kind regards,

Bert Timmerman.