Re-evaluate network notification settings

[Zisu Andrei]

If I open the network indicator and I enable wifi, I get a message that there are available networks and that I should open the indicator.

[Danielle Foré (danrabbit)]

If I remember correctly these notifications are sent directly from network manager. We should probably re-evaluate these notifications and which ones are actually useful.

[Danielle Foré (danrabbit)]

It looks like there are a few keys in "org.gnome.nm-applet" that we might want to set:

"suppress-wireless-networks-available" defaults to false. This is the notification mentioned by OP. I'm on the fence on this one. I've actually been running with no network notifications at all and haven't felt like it's affected me negatively. I'm not sure if this notification is helpful or necessary.

"disable-connected-notifications" defaults to false. I feel like this is unnecessary. If we're an Optimistic UI then it's already assumed that we'll succeed connecting to the network.

"show applet" defaults to true. I haven't noticed that it's showing through the ayatana layer, but we have our own indicator so probably this should be false

[Danielle Foré (danrabbit)]

From Cassidy in Slack:

Being disconnected is good because that's the not normal case and is something you should probably know.

Available networks can be helpful because it lets you know you're not connected (which is not normal) but could be by performing an action (choosing a network)

--

It sounds like we all agree that the connected notification is spammy and to keep the other two.

For what it's worth, these notifications can be completely (not individually) disabled in notification settings.

[Danielle Foré (danrabbit)]

Gonna mark this fix committed based on what was decided above