parameters of assertEqual are misplaced
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
oslo.concurrency |
Fix Released
|
Undecided
|
Haifeng.Yan | ||
oslo.config |
Fix Released
|
Undecided
|
Haifeng.Yan | ||
oslo.context |
Fix Released
|
Undecided
|
Haifeng.Yan | ||
oslo.db |
Fix Released
|
Low
|
Haifeng.Yan | ||
oslo.i18n |
Fix Released
|
Undecided
|
Haifeng.Yan | ||
oslo.log |
Fix Released
|
Undecided
|
Haifeng.Yan | ||
oslo.messaging |
Fix Released
|
Undecided
|
Haifeng.Yan | ||
oslo.middleware |
Fix Released
|
Undecided
|
Haifeng.Yan | ||
oslo.rootwrap |
Fix Released
|
Undecided
|
Haifeng.Yan | ||
oslo.serialization |
Fix Released
|
Undecided
|
Haifeng.Yan | ||
oslo.service |
Fix Released
|
Undecided
|
Haifeng.Yan | ||
oslotest |
Fix Released
|
Undecided
|
Haifeng.Yan |
Bug Description
oslo.config$ grep 'self.assertEqu
oslo_config/
oslo_config/
oslo_config/
oslo_config/
oslo_config/
oslo_config/
oslo_config/
oslo_config/
oslo_config/
oslo_config/
oslo_config/
oslo_config/
oslo_config/
oslo_config/
...
it should be assertEqual(
These misplaces have 2 impacts:
1, giving confusing messages when some tests failed.
2, mislead other developers, new test modules may follow these wrong pattern.
description: | updated |
Changed in oslo.config: | |
assignee: | nobody → Haifeng.Yan (yanheven) |
description: | updated |
description: | updated |
Changed in oslo.config: | |
status: | New → In Progress |
description: | updated |
Changed in oslo.messaging: | |
assignee: | nobody → Haifeng.Yan (yanheven) |
Changed in oslo.service: | |
assignee: | nobody → Haifeng.Yan (yanheven) |
Changed in oslo.db: | |
assignee: | nobody → Haifeng.Yan (yanheven) |
Changed in oslo.db: | |
importance: | Undecided → Low |
status: | New → Confirmed |
Changed in oslotest: | |
assignee: | nobody → Haifeng.Yan (yanheven) |
Changed in oslo.middleware: | |
assignee: | nobody → Haifeng.Yan (yanheven) |
Changed in oslo.concurrency: | |
assignee: | nobody → Haifeng.Yan (yanheven) |
Changed in oslo.context: | |
assignee: | nobody → Haifeng.Yan (yanheven) |
Changed in oslo.serialization: | |
assignee: | nobody → Haifeng.Yan (yanheven) |
Changed in oslo.i18n: | |
assignee: | nobody → Haifeng.Yan (yanheven) |
Changed in oslo.rootwrap: | |
assignee: | nobody → Haifeng.Yan (yanheven) |
Changed in oslo.context: | |
status: | New → Fix Released |
Changed in oslo.middleware: | |
status: | New → Fix Released |
Changed in oslo.i18n: | |
status: | New → Fix Released |
Changed in oslo.db: | |
status: | Confirmed → Fix Released |
Reviewed: https:/ /review. openstack. org/344003 /git.openstack. org/cgit/ openstack/ oslo.config/ commit/ ?id=61224ce932a 520367f8836adbb 2220e29b73d54a
Committed: https:/
Submitter: Jenkins
Branch: master
commit 61224ce932a5203 67f8836adbb2220 e29b73d54a
Author: yan.haifeng <email address hidden>
Date: Tue Jul 19 11:46:45 2016 +0800
Fix parameters of assertEqual are misplaced
Many assertEqual sentences don't follow assertEqual( expected, actual),
this patch fix all of them.
Change-Id: Ia2fbad7a952039 fbba4cddc330872 1a19dd099d1
Closes-Bug: 1604213