Fuel-agent shouldn't use sdist during building packages

[Mikhail Ivanov]

For now, fuel-agent generate sdist for building rpm and deb packages [1][2].
This method doesn't use etc/ subdirectory, that required during building.

If we remove
skip_git_sdist = True
from setup.cfg [3], sdist will be generated with etc/, but we can't use patches before building.

[1]https://packaging-ci.infra.mirantis.net/job/master-pkg-pipeline-centos/4006/consoleFull
[2]https://packaging-ci.infra.mirantis.net/job/master-pkg-mos-build-ubuntu-xenial/1063/consoleFull
[3]https://github.com/openstack/fuel-agent/blob/master/setup.cfg#L38

[Ivan Udovichenko (iudovichenko)]

During .rpm build:
DEBUG: RPM build errors:
DEBUG: + install -d -m 755 /builddir/build/BUILDROOT/fuel-agent-10.0~b1-1.el7~mos4.x86_64/etc/fuel-agent
DEBUG: + install -p -D -m 644 /builddir/build/BUILD/fuel-agent-10.0~b1/etc/fuel-agent/fuel-agent.conf.sample /builddir/build/BUILDROOT/fuel-agent-10.0~b1-1.el7~mos4.x86_64/etc/fuel-agent/fuel-agent.conf
DEBUG: install: cannot stat '/builddir/build/BUILD/fuel-agent-10.0~b1/etc/fuel-agent/fuel-agent.conf.sample': No such file or directory
DEBUG: error: Bad exit status from /var/tmp/rpm-tmp.GxmVLr (%install)
DEBUG: Bad exit status from /var/tmp/rpm-tmp.GxmVLr (%install)
DEBUG: Child return code was: 1
INFO: EXCEPTION: [Error()]
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/mockbuild/trace_decorator.py", line 88, in trace
    result = func(*args, **kw)
  File "/usr/lib/python2.7/site-packages/mockbuild/util.py", line 547, in do
    raise exception.Error("Command failed. See logs for output.\n # %s" % (command,), child.returncode)
Error: Command failed. See logs for output.
 # bash --login -c /usr/bin/rpmbuild -bb --target x86_64 --nodeps /builddir/build/SPECS/fuel-agent.spec
ERROR: Exception(/home/abuild/rpmbuild/fuel-agent-10.0~b1-1.el7~mos4.src.rpm) Config(centos-7-x86_64) 0 minutes 13 seconds
INFO: Results and/or logs in: /home/abuild/buildresult
DEBUG: kill orphans
------------------------------------------------
https://packaging-ci.infra.mirantis.net/job/master-pkg-pipeline-centos/4042/consoleFull

During .deb build:
cp -r /«PKGBUILDDIR»/etc /«PKGBUILDDIR»/debian/fuel-agent/
cp: cannot stat '/«PKGBUILDDIR»/etc': No such file or directory
make[1]: *** [override_dh_install] Error 1
debian/rules:22: recipe for target 'override_dh_install' failed
make[1]: Leaving directory '/«PKGBUILDDIR»'
make: *** [binary] Error 2
debian/rules:12: recipe for target 'binary' failed
dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit status 2
------------------------------------------------
https://packaging-ci.infra.mirantis.net/job/master-pkg-mos-build-ubuntu-xenial/1098/consoleFull

[Mikhail Ivanov (mivanov)]

Related CR: https://review.openstack.org/#/c/343623/

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/fuel-agent 10.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/fuel-agent 10.0.0 release.