graphic/text/bidi.cc::make_ligatures assign values which are never used

[Hans Joachim Desserud]

The method make_ligatures in graphic/text/bidi.cc has two value assignments which doesn't seem to be used. These happen on line 623 (next) and 631 (previous).

Similar assignements happen in the else if branch, but there they are used later. This does not seem to be the case for the values in the if branch. I'm not sure about the intetion here though, so I don't know if the assignments can simply be removed or if they should be used in some way later.

Found by scan-build in r8026

[GunChleoc (gunchleoc)]

These 2 variables are declared outside of the loop, to their values persist throughout the lifetime of the loop and change the loop's behaviour for the next pass. The lines you mention are about skipping diacritics, so the loop can analyze which forms of the basic characters to pick (each Arabic character has a final form, and some of them also have a medial and an initial form).

[Hans Joachim Desserud (hjd)]

>These 2 variables are declared outside of the loop, to their values persist throughout the lifetime of the loop and change the loop's behaviour for the next pass.

But line 610 and 611 will always overwrite the value of these two variables before they are used? So if the code ends up in the if branch and sets these values, I don't see how they survive and can affect the next loop. Let me know if I'm missing something.

[Hans Joachim Desserud (hjd)]

Looks like this was fixed in r8487. It no longer shows up in a scan-build check of recent trunk.

[GunChleoc (gunchleoc)]

Fixed in build20-rc1