Need a network-feature-enabled option for floating IP support

[Matt Riedemann]

Our cloud doesn't support floating IPs but Tempest runs things like this:

https://github.com/openstack/tempest/blob/master/tempest/api/compute/floating_ips/test_floating_ips_actions.py

Regardless of the config.

We need a config option to skip tests that rely on floating IPs, unless we can use the connect_method option to skip if 'fixed' is the connect method.

[Matt Riedemann (mriedem)]

ServerRescueTestJSON also has this issue:

https://github.com/openstack/tempest/blob/master/tempest/api/compute/servers/test_server_rescue.py#L43

[Ghanshyam Mann (ghanshyammann)]

I do not have much experience on production env, so if cloud does not support FIP then what these APIs return (404)?
- POST os-floating-ips
- addFloatingIp

[Matt Riedemann (mriedem)]

Good question, I don't rightly know. You could disable it a few different ways possibly:

1. Disable the related extensions in neutron that deal with L3 routing and floating IPs. That might result in a 500 error in the nova API when trying to perform floating IP actions via the nova API proxies as nova probably only expects those to fail a certain way.

2. Disable the API extension policies in nova that deal with floating IPs, in that case I think you'd get a 401 or a 403.

[Andrea Frittoli (andrea-frittoli)]

There are two separate features, one in neutron and one in nova.
When neutron is available, nova is just a proxy to neutron, when neutron is not available (deprecated) it's nova network that provides floating IPs.

For each of them, I think it's ok to have a feature flag as long as floating IPs are not part of the core API, or if they did not exists in one of the supported releases - but that's not the case.

[Andrea Frittoli (andrea-frittoli)]

Tempest tries and support as many clouds as possible, but only as long as these cloud do not break interoperability. If a feature is part of the core API, and a cloud disables it using policy files or similar means, it's usually not something that we support on Tempest side.

Looking at the interoperability guidelines (https://refstack.openstack.org/#/guidelines) I don't see any reference to floating IPs, so it should be ok to add such flags, or at least one for neutron. The compute tests for floating IPs can be skipped if neutron is available and floating IPs are not.

I don't think at this stage is worth adding a feature flag for nova floating IPs since they are deprecated.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/466344

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/466344
Committed: https://git.openstack.org/cgit/openstack/tempest/commit/?id=3312de38c9903cd86ab3922ef3a153cc7701e0bf
Submitter: Jenkins
Branch: master

commit 3312de38c9903cd86ab3922ef3a153cc7701e0bf
Author: Matthew Treinish <email address hidden>
Date: Fri May 19 12:08:17 2017 -0400

    Add option for whether the cloud supports floating ips

    This commit adds a new config option to specify whether the cloud under
    test supports floating ips or not. Not every cloud supports floating ips
    so we need to be able to handle that and properly skip tests.

    Change-Id: Iedc3c7f9d045408f54d94c34b478fb1b28b593c9
    Closes-Bug: #1603492

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tempest 16.1.0 release.