Flavor ids with leading '0' not supported in Trove

[Peter Stachowski]

When Trove moved to support alphanumeric flavor ids, the case of having a numeric string id with leading zeros was not taken into account. The behavior on the client side is to see if the id is all digits, and if so it is converted to an int. That means that a flavor of '01' will be incorrectly interpreted as '1'. On the server side the code checks if the flavor id can be converted to an int, and if so then sets it as such - the manifestation being that if the str_id is '01' then the id will be set to '1' instead of None as it should be.

The logic should be unified (say to "id.isdigit() and not id.startswith('0')").

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/342457

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/342457
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=afb29a398cc73849ded2ef191513346cebb14834
Submitter: Jenkins
Branch: master

commit afb29a398cc73849ded2ef191513346cebb14834
Author: Peter Stachowski <email address hidden>
Date: Thu Jul 14 22:32:05 2016 +0000

    Support flavor ids with leading '0'

    When Trove moved to support alphanumeric flavor ids, the case of having
    a numeric string id with leading zeros was not taken into account.
    On the server side the code checks if the flavor id can be converted
    to an int, and if so then sets it as such - the manifestation being
    that if the str_id is '01' then the id will be set to '1' instead
    of None as it should be.

    This behavior has been fixed and unit tests created.

    Change-Id: I87a8ac98d4358b75182c987f584c6098398a0c2a
    Depends-On: I5acdec576a2e7da6cbfbb1cfc61c49fbbf7379af
    Closes-Bug: #1603187

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/trove 6.0.0.0b3 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/trove 6.0.0.0b3 development milestone.